qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v2 15/23] target/loongarch: Fix load type for gen_ll


From: Richard Henderson
Subject: Re: [PATCH v2 15/23] target/loongarch: Fix load type for gen_ll
Date: Thu, 26 Dec 2024 14:05:38 -0800
User-agent: Mozilla Thunderbird

On 12/26/24 13:19, Jiaxun Yang wrote:
gen_ll should use tcg_gen_qemu_ld_tl to load t1, as t1 is
in TCGv which means it should be a tl type value.

Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Signed-off-by: Jiaxun Yang <jiaxun.yang@flygoat.com>
---
  target/loongarch/tcg/insn_trans/trans_atomic.c.inc | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/target/loongarch/tcg/insn_trans/trans_atomic.c.inc 
b/target/loongarch/tcg/insn_trans/trans_atomic.c.inc
index 
8584441b543712af8a56aa234c90fd6370c8df01..138bcb3e9999b2c186057c658a019136311f1b82
 100644
--- a/target/loongarch/tcg/insn_trans/trans_atomic.c.inc
+++ b/target/loongarch/tcg/insn_trans/trans_atomic.c.inc
@@ -9,7 +9,7 @@ static bool gen_ll(DisasContext *ctx, arg_rr_i *a, MemOp mop)
      TCGv src1 = gpr_src(ctx, a->rj, EXT_NONE);
      TCGv t0 = make_address_i(ctx, src1, a->imm);
- tcg_gen_qemu_ld_i64(t1, t0, ctx->mem_idx, mop);
+    tcg_gen_qemu_ld_tl(t1, t0, ctx->mem_idx, mop);
      tcg_gen_st_tl(t0, tcg_env, offsetof(CPULoongArchState, lladdr));
      tcg_gen_st_tl(t1, tcg_env, offsetof(CPULoongArchState, llval));
      gen_set_gpr(a->rd, t1, EXT_NONE);


Reviewed-by: Richard Henderson <richard.henderson@linaro.org>

r~



reply via email to

[Prev in Thread] Current Thread [Next in Thread]