Re: [PATCH v2 12/23] target/loongarch: Scrutinise TCG bitops translation for 32 bit build

[Richard Henderson]

On 12/26/24 14:08, Jiaxun Yang wrote:
> 在2024年12月26日十二月 下午9:55，Richard Henderson写道：
> [...]
> > While this allows the code to compile, (1) the functions are unused and
> > (2) they do not
> > compute the required results.  For me, the latter is concerning.
> >
> > I'd suggest moving GEN_FALSE_TRANS out of trans_privileged.c.inc, then
> >
> > #ifdef TARGET_LOONGARCH64
> > // all gen_foo_d
> > TRANS(bytepick_d, 64, gen_rrr_sa, EXT_NONE, EXT_NONE, gen_bytepick_d)
> > // etc
> > #else
> > GEN_FALSE_TRANS(bytepick_d)
> > // etc
> > #endif
>
> Thanks for the insight!
>
> I'm actually thinking about introducing an TRANS64 which resolves to
> GEN_FALSE_TRANS if not on TARGET_LOONGARCH64.

That works too!


r~