Re: regex.c not 64-bit clean (?)

[Eric Blake]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Hi Santiago,

[adding bug-gnulib, dropping bug-m4]

According to Santiago Vila on 6/12/2006 12:07 PM:
>> I suspect it will be, since I really haven't touched regex.c that much
>> since 1.4.4.  Then try this patch which pulls the latest regex.c from
>> gnulib:
>>
>> $ make clean
>> $ patch -p0 < email
>> $ GNULIB_TOOL=../gnulib/gnulib-tool ./bootstrap
>> $ ./configure CFLAGS='-Wall -Werror'
>> $ make
> 
> This is what happens:
> 
> make  all-recursive
> make[1]: Entering directory `/home/sanvila/tmp/m4'
> Making all in examples
> make[2]: Entering directory `/home/sanvila/tmp/m4/examples'
> make[2]: Nothing to be done for `all'.
> make[2]: Leaving directory `/home/sanvila/tmp/m4/examples'
> Making all in lib
> make[2]: Entering directory `/home/sanvila/tmp/m4/lib'
> cp ./alloca_.h alloca.h-t
> mv alloca.h-t alloca.h
> make  all-am
> make[3]: Entering directory `/home/sanvila/tmp/m4/lib'
> gcc -DHAVE_CONFIG_H -I. -I. -I..     -Wall -Werror -c strnlen1.c
> gcc -DHAVE_CONFIG_H -I. -I. -I..     -Wall -Werror -c xalloc-die.c
> In file included from /usr/include/stdlib.h:433,
>                  from xalloc-die.c:26:
> /usr/include/sys/types.h:110: error: two or more data types in declaration 
> specifiers
> make[3]: *** [xalloc-die.o] Error 1

Sounds like we have a gnulib bug on our hands, in xalloc-die.

OK, remind me again what 'uname -a', 'gcc --version', and 'config.guess'
report.  Also, what does 'sed -ne 90,110p /usr/include/sys/types.h' show?

Really nice would be narrowing in on what the preprocessor saw:

$ cd lib
$ gcc -E -DHAVE_CONFIG_H -I. -I.. xalloc-die.c

and figure where in the output that line from stdlib was showing up.

> 
> This is on a debian machine with architecture "ia64". Unfortunately,
> I am not root, so I can't change anything in the build environment
> (in fact I've had to do the cvs and bootstrap parts in another machine).
> 

Meanwhile, the original question was whether the gnulib version of regex.c
solved the 64-bit bugs present in the years-old version that m4 1.4.4
used.  Now that you have gnulib checked out, try:

$ cd gnulib
$ CFLAGS='-Wall -Werror' gnulib-tool --test regex

and see if that compiles cleanly.  If so, I can go ahead and commit my
patch to use gnulib for m4 1.4.5.

- --
Life is short - so eat dessert first!

Eric Blake             address@hidden
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.2.1 (Cygwin)
Comment: Public key at home.comcast.net/~ericblake/eblake.gpg
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFEj1nr84KuGfSFAYARAseSAJ9GmOjS9eV/MxgUSXYTajX/o3SO6QCffDA4
8VvHE257xNsctjBb0sGo4oo=
=WRUD
-----END PGP SIGNATURE-----