Re: [Lynx-dev] ..on SOCKS5 support

[Steffen Nurpmeso]

Hello.

Steffen Nurpmeso wrote in <address@hidden>:
 |Steffen Nurpmeso wrote in <address@hidden>:
 ||Thomas Dickey wrote in <20190916003351.7x3j6ubnoerj7ysh@prl-debianold-64\
 ||.jexium-island.net>:
 |||On Sun, Sep 15, 2019 at 12:31:17AM +0200, Steffen Nurpmeso wrote:
 |||> Steffen Nurpmeso wrote in <address@hidden>:
 |||>|Steffen Nurpmeso wrote in <address@hidden>:
 |||>||please excuse the late reply.
 |||>  ...
 |||>|Right.  So here is a working patch, porting over my own SOCKS5
 |||> 
 |||> Yep, but it should set status to an error code if the hostname
 |||> length check in the upper conditional fails.  Sorry.
 |||
 |||well... I'll have to set up something for testing, but here's something
 |||more like the style of lynx
 |
 |I see we would also have crashed if the hostname length would have
 |been excessed.  Ah, it also was the last night of the proms, i am
 |sorry.  But i wanted to post it on Saturday, after having said
 |i will do it Wednesday or Thursday.  Other than that i hope it is
 |fine.

Now here stylified the way you did, with your jumps copied over
(but placed at end of function to pessimize errors), Thorsten's
htons() replacement, and style adjusted to what seems appropriate
for lynx.  I did not initialize all locals due to the reordering
of the first conditional (i would in fact rather use a struct to
collect all that, and do the SOCKS5 address lookup only once, as
the address is fixed in lynx; anyway).  Works here from a short
test.  I also added the word "to" to manual and help string.

--steffen
|
|Der Kragenbaer,                The moon bear,
|der holt sich munter           he cheerfully and one by one
|einen nach dem anderen runter  wa.ks himself off
|(By Robert Gernhardt)

lynx-socks5-2.patch
Description: Text Data