Re: libtool-1.3.5 memory leak

[Robert Boehne]

Alexandre Oliva wrote:
> 
> On Apr 16, 2001, Chad Miller <address@hidden> wrote:
> 
> >> On Apr 16, 2001, Chad Miller <address@hidden> wrote:
> >> > This may be fixed in the devel line -- I don't know.
> 
> > On Mon, Apr 16, 2001 at 04:43:55PM -0300, Alexandre Oliva wrote:
> >> However, we'll need a ChangeLog entry.  Chad, care to post one?
> >> Thanks in advance.
> 
> > I don't think I understand the code sufficiently to provide a description
> > that would be of much use.  :/  Sorry.  This was my first look at libtool
> > source.
> 
> Something like this would do.  We just want contributors to post their
> ChangeLog entries because they generally have a good understanding of
> the problem, which helps us evaluate the patch.
> 
> Index: ChangeLog
> from  Chad Miller <address@hidden>
> 
>         * libltdl/ltdl.c (lt_dlopen): Don't leak memory in successful
>         dlopen of .la library.
> 

How is this? OK to commit?

Robert

-- 
Robert Boehne             Software Engineer
Ricardo Software   Chicago Technical Center
TEL: (630)789-0003 x. 238
FAX: (630)789-0127
email:  address@hidden

ChangeLog entry:

2001-04-16 Chad Miller  <address@hidden>

        * libltdl/ltdl.c (lt_dlopen): Fixed a memory leak.


Index: libltdl/ltdl.c
===================================================================
RCS file: /cvsroot/libtool/libtool/libltdl/ltdl.c,v
retrieving revision 1.64.2.19
diff -u -r1.64.2.19 ltdl.c
--- libltdl/ltdl.c      2000/09/04 01:53:05     1.64.2.19
+++ libltdl/ltdl.c      2001/04/16 22:23:43
@@ -1365,6 +1365,7 @@
                        free_vars(name, dir, dlname, old_name, libdir, deplibs);
                        return 0;
                }
+               free_vars(NULL, NULL, dlname, old_name, libdir, deplibs);
                if (handle != newhandle) {
                        unload_deplibs(handle);
                }