Re: [Zutils-bug] Some issues on Solaris (patches referenced)

[Dagobert Michelsen]

Hi Antonio,

Am 19.11.2010 um 21:15 schrieb Antonio Diaz Diaz:
> Dagobert Michelsen wrote:
>> I compiled zutils 0.8 for Solaris and some patches are needed which you may
>> want to adopt / adjust for proper detection.
> 
> Thanks for reporting this. I'll comment on each patch separately.
> 
>> On Solaris there is no stdint.h, but inttypes.h.
> 
> But I neither need nor want all the crap of inttypes.h included in zutils. I 
> think it is time for Solaris to start implementing stdint.h.

This may be your valid opinion. However, it means every person
trying to compile zutils on Solaris will have to patch this on
his own. Why not make the life of others easier?

>> Additionally, signal.h is needed in some files.
> 
> Those files already #include <csignal>. Why is signal.h also needed?

If it is omitted the following errors are issued:

> "zdiff.cc", line 426: Warning (Anachronism): Formal argument 1 of type extern 
> "C" void(*)() in call to std::atexit(extern "C" void(*)()) is being passed 
> void(*)().
> "zdiff.cc", line 458: Error: The function "kill" must have a prototype.
> "zdiff.cc", line 459: Error: The function "kill" must have a prototype.

csignal on the Sun Studio 12 compiler is

> current9s% more /opt/SUNWspro/prod/include/CC/std/csignal
> // -*- C++ -*-
> /*
>         Copyright 07/15/04 Sun Microsystems, Inc. All Rights Reserved
> */
> 
> #ifndef _SIGNAL_H
> 
> #include <iso/signal_iso.h>
> 
> #endif /* _SIGNAL_H */

which mainly defined "signal" and "raise", but not "kill".

>> The call can be applied to two function signatures and should be made unique:
>> "zcat.cc", line 48: Error: Overloading ambiguity between 
>> "std::string::insert(char*, unsigned, char)" and 
>> "std::string::insert(unsigned, unsigned, char)".
> 
> Please, can you see if using the suffix 'U' like in the following line works?
>    else str.insert( 0U, 1, '1' );

Yep, this also does the trick.


Best regards

  -- Dago