Re: [PATCH] Fix regexps for coloured shell prompts, and a typo.

[Steve Youngs]

|--==> "KG" == Kai Gro <address@hidden> writes:

  KG> Steve Youngs <address@hidden> writes:
  >>Without this patch I was getting a void variable error

  KG> Thank you for fixing that one.

You're welcome.

  >>and couldn't connect to any user/host that used colour control
  >>characters in the shell prompt.

  KG> I don't like that part of the change.  Why didn't you look why I
  KG> introduced \\' in the first place?  There was a reason for me to do
  KG> that.

I isearch'd lisp/ChangeLog for "regexp" but it didn't turn up anything
useful. :-(

  KG> /----
  KG> | 2002-05-22  Kai Großjohann  <address@hidden>

[...]

  KG> Oh, now I see that there was no reason given.  Sorry about this.  So

...I wouldn't have found what I was looking for anyway. :-P

  KG> here is the reason: a lot of people have a motd that contains things
  KG> like this:

  KG> /----
  KG> | Linux lucy 2.4.19-pre10-ls6 #1 Wed Jun 5 11:13:06 CEST 2002 i686 unknown
  KG> \----

Ah!  Good reason to have "\\'" in the regexps.  I'll revert that part
of the patch in a jiffy.  And...

  KG> Therefore I suggest to take a different approach: tell their shell
  KG> init files to abstain from ansi escapes in shell prompts when $TERM
  KG> is "dumb".  Tramp conveniently sets $TERM to "dumb" for this very
  KG> reason :-)  

...do that.  Please accept my apologies for breaking things.

  >>BTW, what happened to the "tramp-checkins" list?  I'm not getting CVS
  >>commit notices anymore. :-(

  KG> I hope I have recreated the list.  I forgot to do that before.  I have
  KG> copied and pasted magic into CVSROOT/loginfo and CVSROOT/commitinfo
  KG> without a deeper understanding of what's going on.

I'll see if I get a notice when I fix up this patch.


-- 
|---<Steve Youngs>---------------<GnuPG KeyID: 10D5C9C5>---|
|            XEmacs - It's not just an editor.             |
|                    It's a way of life.                   |
|------------------------------------<address@hidden>---|