Re: [Swftools-common] swfdump core dump

[Chris Miles]

Hi Chris,

Okay I'm happy to do that as and when.

Chris

On 05/02/15 04:13, RDP wrote:
> On 4 February 2015 at 16:50, Chris Miles <address@hidden> wrote:
>> When using swfdump on swf's with a large constant pool (more than 1024 
>> strings) swfdump crashes.
>>
>> The below patch allows up to 8192 strings in the pool and stops the crash if 
>> the limit is exceeded.
>>
>> Chris
>>
>> $ git branch -v
>> * master b6e946b fix crashes reported by Debian Cylab Mayhem Team
>>
>> $ git diff
>> diff --git a/lib/modules/swfaction.c b/lib/modules/swfaction.c
>> index bd248ec..52d966c 100644
>> --- a/lib/modules/swfaction.c
>> +++ b/lib/modules/swfaction.c
>> @@ -23,7 +23,8 @@
>>
>>  #include "../rfxswf.h"
>>
>> -#define MAX_LOOKUP 1024   // make cross references in dumps
>> +//#define MAX_LOOKUP 1024   // make cross references in dumps
>> +#define MAX_LOOKUP 8192   // make cross references in dumps
>>
>>  struct Action
>>  {
>> @@ -466,7 +467,7 @@ void swf_DumpActions(ActionTAG*atag, char*prefix)
>>                           U32 offset = value[0]+(value[1]<<8);
>>                           printf(" Lookup16:%d", offset);
>>  #ifdef MAX_LOOKUP
>> -                         if (lookup[offset])
>> +                         if (offset < MAX_LOOKUP && lookup[offset])
>>                             printf(" (\"%s\")",lookup[offset]);
>>  #endif
>>                       } else {
> Hi Chris,
>
> Thanks for submitting the above patch.
>
> Further SWFTools development has temporarily ceased, however
> consideration is begin given to a
> maintaining the project in a more accessible way, including a bug
> tracker, and  Git repository
>  based upon the last 'official' repo maintained.
>
> When ( if ) the above occurs, you may wish to apply your patch directly.
>
> Regards,
>
>
> Chris.
>
> ---------------
> SWFTools-common is a self-managed list. To subscribe/unsubscribe, or amend an 
> existing subscription, please kindly point your favourite web browser 
> at:<http://lists.nongnu.org/mailman/listinfo/swftools-common>

The information contained in this email, including any attachments, is intended 
solely for use by the individual or entity named above and may be confidential. 
If you have received this email in error please delete it and notify the sender 
immediately; you should not retain the message or disclose its contents to 
anyone. Thank you. Yell is a brand of hibu (UK) Limited. Registered Office: One 
Reading Central, Forbury Road, Reading, Berkshire, RG1 3YL. Registered in 
England and Wales No. 4205228” VAT Number: GB 765 346 017 © hibu (UK) Limited 
2014. All rights reserved. Yell, Yellow Pages, hibu and other TM are trademarks 
of hibu.