Re: [PATCH 3/3] Add login by email address and revise some messages to the user in Savane

[Ineiev]

On Fri, Dec 11, 2020 at 02:57:10PM +0100, Andrea G. Monaco wrote:
>   > As a matter of fact, people rarely forget their logins---typically,
>   > they forget their passwords and lose email accounts; when they do
>   > forget their logins, the admins process their requests quite fast.
>
> True, but it does happen. The patch would avoid admins' involvement and
> save time for everyone.

Not necessarily. the requests are quite few, they may not justify
the efforts to work out and maintain the extra code.

>   > Some of those changes are actually wrong, many other are so minor
>   > that I wonder if they worth the additional translators' work.
>
> Which changes are wrong? If you took the time to explain that, perhaps
> it could be a learning opportunity for me and other people.

For instance, changes in account_pwvalid() leave the instructions
for the translators outdated; and instead of modifying those strings,
I think it would be better to restore the original message like

@@ -149,6 +149,7 @@ function account_pwvalid ($newpass, $oldpass = '', $user = 
'')

   if ($check !== 0)
     {
+      $check = sprintf(_("Bad password (%s)"), $check);
       fb($check, 1);
       return 0;
     }

>   > We don't ask for any government-issued IDs. when people aren't
>   > willing to give their "real" name (whatever it may mean), they
>   > submit something else.
>
> I agree. But people may feel some pressure if asked about their Real
> Name. Maybe Full Name is less loaded.

Then we could look for something yet less loaded, like Name.

signature.asc
Description: PGP signature