Re: [PATCH] linux-user: Avoid mmap of the last byte of the reserved_va

[Richard Henderson]

On 6/30/23 18:06, Michael Tokarev wrote:
> 29.06.2023 11:08, Richard Henderson wrote:
> > There is an overflow problem in mmap_find_vma_reserved:
> > when reserved_va == UINT32_MAX, end may overflow to 0.
> > Rather than a larger rewrite at this time, simply avoid
> > the final byte of the VA, which avoids searching the
> > final page, which avoids the overflow.
>
> This hack appears to fix known issues and apparently does not
> introduce regressions.
>
> Can it be applied to master and picked up from there, since
> master is also broken?  You can revert it in the subsequent
> patchset like the one you posted today.
>
> You can add my:
>
> Tested-by: Michael Tokarev <mjt@tls.msk.ru>
> Reviewed-by: Michael Tokarev <mjt@tls.msk.ru>

Yes, that's a good idea.  Queued to tcg-next.


r~