[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-stable] [PATCH v2 3/4] tests: add QMP input visitor test for u
|
From: |
Eric Blake |
|
Subject: |
Re: [Qemu-stable] [PATCH v2 3/4] tests: add QMP input visitor test for unions with no discriminator |
|
Date: |
Wed, 17 Sep 2014 16:33:36 -0600 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.1.0 |
On 09/17/2014 03:32 PM, Michael Roth wrote:
> This more of an exercise of the dealloc visitor, where it may
s/This more/This is more/
> erroneously use an uninitialized discriminator field as indication
> that union fields corresponding to that discriminator field/type are
> present, which can lead to attempts to free random chunks of heap
> memory.
>
> Cc: address@hidden
> Reviewed-by: Eric Blake <address@hidden>
> Reviewed-by: Paolo Bonzini <address@hidden>
> Signed-off-by: Michael Roth <address@hidden>
> ---
> tests/qapi-schema/qapi-schema-test.json | 10 ++++++++++
> tests/qapi-schema/qapi-schema-test.out | 3 +++
> tests/test-qmp-input-strict.c | 17 +++++++++++++++++
> 3 files changed, 30 insertions(+)
>
R-b still stands.
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
- [Qemu-stable] [PATCH v2 0/4] qapi: fix crash in dealloc visitor for union types, Michael Roth, 2014/09/17
- [Qemu-stable] [PATCH v2 1/4] qapi: add visit_start_union and visit_end_union, Michael Roth, 2014/09/17
- [Qemu-stable] [PATCH v2 3/4] tests: add QMP input visitor test for unions with no discriminator, Michael Roth, 2014/09/17
- Re: [Qemu-stable] [PATCH v2 3/4] tests: add QMP input visitor test for unions with no discriminator,
Eric Blake <=
- [Qemu-stable] [PATCH v2 2/4] qapi: dealloc visitor, implement visit_start_union, Michael Roth, 2014/09/17
- [Qemu-stable] [PATCH v2 4/4] qemu-iotests: Test missing "driver" key for blockdev-add, Michael Roth, 2014/09/17