[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 13/26] rust: qom: automatically use Drop trait to implement i
|
From: |
Zhao Liu |
|
Subject: |
Re: [PATCH 13/26] rust: qom: automatically use Drop trait to implement instance_finalize |
|
Date: |
Wed, 11 Dec 2024 00:16:15 +0800 |
On Mon, Dec 09, 2024 at 01:37:04PM +0100, Paolo Bonzini wrote:
> Date: Mon, 9 Dec 2024 13:37:04 +0100
> From: Paolo Bonzini <pbonzini@redhat.com>
> Subject: [PATCH 13/26] rust: qom: automatically use Drop trait to implement
> instance_finalize
> X-Mailer: git-send-email 2.47.1
>
> Replace the customizable INSTANCE_FINALIZE with a generic function
> that drops the Rust object.
>
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> ---
> rust/qemu-api/src/definitions.rs | 10 ++++++++--
> 1 file changed, 8 insertions(+), 2 deletions(-)
>
Great idea. It nicely balances the differences between Rust and C QOM
conventions.
Reviewed-by: Zhao Liu <zhao1.liu@intel.com>
- [PATCH 06/26] rust: add a bit operation module, (continued)
- [PATCH 06/26] rust: add a bit operation module, Paolo Bonzini, 2024/12/09
- [PATCH 10/26] rust: qom: move ClassInitImpl to the instance side, Paolo Bonzini, 2024/12/09
- [PATCH 09/26] rust: qom: convert type_info! macro to an associated const, Paolo Bonzini, 2024/12/09
- [PATCH 12/26] rust: qdev: move bridge for realize and reset functions out of pl011, Paolo Bonzini, 2024/12/09
- [PATCH 13/26] rust: qom: automatically use Drop trait to implement instance_finalize, Paolo Bonzini, 2024/12/09
- Re: [PATCH 13/26] rust: qom: automatically use Drop trait to implement instance_finalize,
Zhao Liu <=
- [PATCH 14/26] rust: qom: move bridge for TypeInfo functions out of pl011, Paolo Bonzini, 2024/12/09
- Re: [PATCH 14/26] rust: qom: move bridge for TypeInfo functions out of pl011, Zhao Liu, 2024/12/10
- Re: [PATCH 14/26] rust: qom: move bridge for TypeInfo functions out of pl011, Paolo Bonzini, 2024/12/10
- Re: [PATCH 14/26] rust: qom: move bridge for TypeInfo functions out of pl011, Zhao Liu, 2024/12/11
- Re: [PATCH 14/26] rust: qom: move bridge for TypeInfo functions out of pl011, Paolo Bonzini, 2024/12/11
- Re: [PATCH 14/26] rust: qom: move bridge for TypeInfo functions out of pl011, Zhao Liu, 2024/12/11
- Re: [PATCH 14/26] rust: qom: move bridge for TypeInfo functions out of pl011, Paolo Bonzini, 2024/12/12
- Re: [PATCH 14/26] rust: qom: move bridge for TypeInfo functions out of pl011, Zhao Liu, 2024/12/13