[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH 19/20] tests/functional: remove hacky sleep from the tests
From: |
Alex Bennée |
Subject: |
[PATCH 19/20] tests/functional: remove hacky sleep from the tests |
Date: |
Tue, 10 Dec 2024 20:43:48 +0000 |
We have proper detection of prompts now so we don't need to guess with
sleep() sprinkled through the test. The extra step of calling halt is
just to flush the final bits of the log (although the last line is
still missed).
Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
---
tests/functional/test_aarch64_virt.py | 22 ++++++++++------------
1 file changed, 10 insertions(+), 12 deletions(-)
diff --git a/tests/functional/test_aarch64_virt.py
b/tests/functional/test_aarch64_virt.py
index c967da41b4..801300607c 100755
--- a/tests/functional/test_aarch64_virt.py
+++ b/tests/functional/test_aarch64_virt.py
@@ -107,18 +107,16 @@ def common_aarch64_virt(self, machine):
'virtio-blk-device,drive=scratch')
self.vm.launch()
- self.wait_for_console_pattern('Welcome to Buildroot')
- time.sleep(0.1)
- exec_command(self, 'root')
- time.sleep(0.1)
- exec_command(self, 'dd if=/dev/hwrng of=/dev/vda bs=512 count=4')
- time.sleep(0.1)
- exec_command(self, 'md5sum /dev/vda')
- time.sleep(0.1)
- exec_command(self, 'cat /proc/interrupts')
- time.sleep(0.1)
- exec_command(self, 'cat /proc/self/maps')
- time.sleep(0.1)
+
+ ps1='#'
+ self.wait_for_console_pattern('login:')
+ exec_command_and_wait_for_pattern(self, 'root', ps1)
+ exec_command_and_wait_for_pattern(self, 'cat /proc/interrupts', ps1)
+ exec_command_and_wait_for_pattern(self, 'cat /proc/self/maps', ps1)
+ exec_command_and_wait_for_pattern(self, 'uname -a', ps1)
+ exec_command_and_wait_for_pattern(self, 'dd if=/dev/hwrng of=/dev/vda
bs=512 count=4', ps1)
+ exec_command_and_wait_for_pattern(self, 'md5sum /dev/vda', ps1)
+ exec_command_and_wait_for_pattern(self, 'halt -n', 'reboot: System
halted')
def test_aarch64_virt_gicv3(self):
self.common_aarch64_virt("virt,gic_version=3")
--
2.39.5
- Re: [PATCH 20/20] tests/functional: extend test_aarch64_virt with vulkan test, (continued)
[PATCH 08/20] tests/functional: update the ppc32 tuxrun tests, Alex Bennée, 2024/12/10
[PATCH 05/20] tests/functional: update the mips32el tuxrun tests, Alex Bennée, 2024/12/10
[PATCH 11/20] tests/functional: update the riscv64 tuxrun tests, Alex Bennée, 2024/12/10
[PATCH 13/20] tests/functional: update the sparc64 tuxrun tests, Alex Bennée, 2024/12/10
[PATCH 16/20] util/qemu-timer: fix indentation, Alex Bennée, 2024/12/10
[PATCH 14/20] tests/functional: update the x86_64 tuxrun tests, Alex Bennée, 2024/12/10
[PATCH 19/20] tests/functional: remove hacky sleep from the tests,
Alex Bennée <=
[PATCH 17/20] tests/qtest: move clock_steps to after checks, Alex Bennée, 2024/12/10
[PATCH 18/20] system/qtest: properly feedback results of clock_[step|set], Alex Bennée, 2024/12/10