Re: [PATCH v2 03/13] hw/ppc/spapr: Replace sprintf() by snprintf()

[Harsh Prateek Bora]

On 4/11/24 15:45, Philippe Mathieu-Daudé wrote:
> sprintf() is deprecated on Darwin since macOS 13.0 / XCode 14.1,
> resulting in painful developper experience.

s/developper/developer ?

> Replace sprintf() by snprintf() in order to avoid:
>
>    hw/ppc/spapr.c:385:5: warning: 'sprintf' is deprecated:
>      This function is provided for compatibility reasons only.
>      Due to security concerns inherent in the design of sprintf(3),
>      it is highly recommended that you use snprintf(3) instead.
>      [-Wdeprecated-declarations]
>        sprintf(mem_name, "memory@%" HWADDR_PRIx, start);
>        ^
>    1 warning generated.
>
> Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>

With the typo fixed,

Reviewed-by: Harsh Prateek Bora <harshpb@linux.ibm.com>

> ---
>   hw/ppc/spapr.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/hw/ppc/spapr.c b/hw/ppc/spapr.c
> index e9bc97fee0..9e97992c79 100644
> --- a/hw/ppc/spapr.c
> +++ b/hw/ppc/spapr.c
> @@ -382,7 +382,7 @@ static int spapr_dt_memory_node(SpaprMachineState *spapr, 
> void *fdt, int nodeid,
>       mem_reg_property[0] = cpu_to_be64(start);
>       mem_reg_property[1] = cpu_to_be64(size);
>   
> -    sprintf(mem_name, "memory@%" HWADDR_PRIx, start);
> +    snprintf(mem_name, sizeof(mem_name), "memory@%" HWADDR_PRIx, start);
>       off = fdt_add_subnode(fdt, 0, mem_name);
>       _FDT(off);
>       _FDT((fdt_setprop_string(fdt, off, "device_type", "memory")));