[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-ppc] [PATCH 08/16] MAINTAINERS: Add missing entries for the TI
From: |
Philippe Mathieu-Daudé |
Subject: |
Re: [Qemu-ppc] [PATCH 08/16] MAINTAINERS: Add missing entries for the TI touchscreen devices |
Date: |
Mon, 7 Jan 2019 12:44:46 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.3.1 |
On 1/7/19 9:05 AM, Thomas Huth wrote:
> On 2019-01-07 09:02, Philippe Mathieu-Daudé wrote:
>> Hi Thomas,
>>
>> On 1/7/19 8:18 AM, Thomas Huth wrote:
>>> On 2019-01-04 18:58, Philippe Mathieu-Daudé wrote:
>>>> Signed-off-by: Philippe Mathieu-Daudé <address@hidden>
>>>> ---
>>>> MAINTAINERS | 2 ++
>>>> 1 file changed, 2 insertions(+)
>>>>
>>>> diff --git a/MAINTAINERS b/MAINTAINERS
>>>> index f571b29077..03872552ee 100644
>>>> --- a/MAINTAINERS
>>>> +++ b/MAINTAINERS
>>>> @@ -640,6 +640,7 @@ M: Peter Maydell <address@hidden>
>>>> L: address@hidden
>>>> S: Odd Fixes
>>>> F: hw/arm/nseries.c
>>>> +F: hw/input/tsc2*.c
>>>> F: include/hw/display/blizzard.h
>>>> F: include/hw/misc/cbus.h
>>>>
>>>> @@ -649,6 +650,7 @@ M: Peter Maydell <address@hidden>
>>>> L: address@hidden
>>>> S: Odd Fixes
>>>> F: hw/arm/palm.c
>>>> +F: hw/input/tsc2*.c
>>>
>>> The Palm machine does not seem to use tsc2005, does it? So I think this
>>> entry here is wrong.
>>
>> It does use another touchscreen controller, the tsc2102, which in the
>> next patch are declared in the same header (you suggested "tsc2xxx.h):
>
> So using the tsc2*.c wildcard for the *C* file is still wrong here,
> isn't it?
Oh I got it now! Yes, you are right :) I'll update.
- [Qemu-ppc] [PATCH 05/16] hw/devices: Move Blizzard declarations into a new header, (continued)
[Qemu-ppc] [PATCH 09/16] hw/devices: Move TI touchscreen declarations into a new header, Philippe Mathieu-Daudé, 2019/01/04
[Qemu-ppc] [PATCH 10/16] typedefs: Remove MouseTransformInfo, Philippe Mathieu-Daudé, 2019/01/04
[Qemu-ppc] [PATCH 11/16] typedefs: Remove PS2State, Philippe Mathieu-Daudé, 2019/01/04
[Qemu-ppc] [PATCH 12/16] hw/devices: Move LAN9118 declarations into a new header, Philippe Mathieu-Daudé, 2019/01/04
[Qemu-ppc] [PATCH 13/16] hw/net/ne2000-isa: Add guards to the header, Philippe Mathieu-Daudé, 2019/01/04
[Qemu-ppc] [PATCH 14/16] hw/net/lan9118: Export TYPE_LAN9118 and use it instead of hardcoded string, Philippe Mathieu-Daudé, 2019/01/04