Re: [Qemu-ppc] [Qemu-devel] [PATCH 1/5] scsi: add lsi53c8xx_handle_legacy_cmdline() function

[Philippe Mathieu-Daudé]

On 9/19/18 7:20 PM, Mark Cave-Ayland wrote:
> This is the function that will soon be used to replace lsi53c895a_create() and
> lsi53c810_create().
> 
> Signed-off-by: Mark Cave-Ayland <address@hidden>
> Reviewed-by: Thomas Huth <address@hidden>

This could be squashed in the next patch (2/5).

Reviewed-by: Philippe Mathieu-Daudé <address@hidden>

> ---
>  hw/scsi/lsi53c895a.c | 7 +++++++
>  include/hw/pci/pci.h | 1 +
>  2 files changed, 8 insertions(+)
> 
> diff --git a/hw/scsi/lsi53c895a.c b/hw/scsi/lsi53c895a.c
> index 955ba94800..8f5ab82d57 100644
> --- a/hw/scsi/lsi53c895a.c
> +++ b/hw/scsi/lsi53c895a.c
> @@ -2290,3 +2290,10 @@ void lsi53c810_create(PCIBus *bus, int devfn)
>  
>      scsi_bus_legacy_handle_cmdline(&s->bus);
>  }
> +
> +void lsi53c8xx_handle_legacy_cmdline(DeviceState *lsi_dev)
> +{
> +    LSIState *s = LSI53C895A(lsi_dev);
> +
> +    scsi_bus_legacy_handle_cmdline(&s->bus);
> +}
> diff --git a/include/hw/pci/pci.h b/include/hw/pci/pci.h
> index 990d6fcbde..0d907dc084 100644
> --- a/include/hw/pci/pci.h
> +++ b/include/hw/pci/pci.h
> @@ -709,6 +709,7 @@ PCIDevice *pci_create_simple(PCIBus *bus, int devfn, 
> const char *name);
>  
>  void lsi53c895a_create(PCIBus *bus);
>  void lsi53c810_create(PCIBus *bus, int devfn);
> +void lsi53c8xx_handle_legacy_cmdline(DeviceState *lsi_dev);
>  
>  qemu_irq pci_allocate_irq(PCIDevice *pci_dev);
>  void pci_set_irq(PCIDevice *pci_dev, int level);
>