Re: [Qemu-ppc] [PATCH v2] tests/postcopy: Use KVM on ppc64 only if it is KVM-HV

[Laurent Vivier]

On 16/11/2016 11:26, Thomas Huth wrote:
> On 16.11.2016 11:18, Laurent Vivier wrote:
>>
>>
>> On 16/11/2016 11:14, Thomas Huth wrote:
>>> The ppc64 postcopy test does not work with KVM-PR, and it is also
>>> causing annoying warning messages when run on a x86 host. So let's
>>> use KVM here only if we know that we're running with KVM-HV (which
>>> automatically also means that we're running on a ppc64 host), and
>>> use TCG otherwise.
>>>
>>> Signed-off-by: Thomas Huth <address@hidden>
>>> ---
>>>  v2:
>>>  - Check also /dev/kvm to make sure that we're allowed to access KVM
>>
>> I'm not sure it's a good idea as we will fail silently whereas QEMU
>> sends an error message. It's common mistake we should be aware of.
> 
> But if I run "make check" as a normal user who does not have access
> right to /dev/kvm, this is IMHO not a fatal error (since this could be
> on purpose), thus we should not issue an error message here and simply
> use TCG instead.
> 
> If you want to see at least a warning in this case, I think we should
> rather go with v1 of this patch that used "kvm:tcg".

I think it's better to have a warning, so let's got with v1...

Laurent