Re: [Qemu-ppc] [Qemu-devel] [PATCH 01/18] target-ppc: Add Flag for Power ISA V2.06

[Scott Wood]

On Thu, 2013-12-19 at 09:35 -0600, Tom Musta wrote:
> It turns out that all of the instructions added in this series are *not* 
> implemented
> in e500mc.  So the patch, as is, is correct for e500mc as well as P7/P8.

That may be true for e500mc (for some reason it didn't look that way
when I checked yesterday), but e5500 supports bpermd.

e6500 (not in QEMU yet, but hopefully added soon) additionally supports
lbarx/lharx/stbcx./sthcx.

> The problem with this patch series seems to be that previously implemented 
> ISA2.06
> instructions were given their own flags (e.g. PPC_POPCNTWD).  But this series 
> attempted
> to use a single flag for all of base ISA 2.06.
> 
> Based on Alex's suggestion, I propose that I re-implement, eliminating 
> PPC2_ISA206 and
> replacing it with the following new flags:
> 
>   - PPC2_PERMUTE_206 (bpermd)
>   - PPC2_DIV_EXT_206 (div[wd]e[u])
>   - PPC2_ATOMIC_206 (l[bh]arx, st[bh]cx.)
>   - PPC2_FP_CVT_206 (fcfid*, fcti[dw]u[z], lfiwzx)
>   - PPC2_FP_TEST_206 (ftdiv, ftsqrt)
> 
> Comments?

Sounds good.

-Scott