Re: [PATCH v2 13/31] tests/functional: switch over to using self.scratch

qemu-devel

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v2 13/31] tests/functional: switch over to using self.scratch

From:	Thomas Huth
Subject:	Re: [PATCH v2 13/31] tests/functional: switch over to using self.scratch_file()
Date:	Thu, 12 Dec 2024 10:33:34 +0100
User-agent:	Mozilla Thunderbird

On 11/12/2024 18.26, Daniel P. Berrangé wrote:

Replace any instances of

   os.path.join(self.workdir, ".../...")
   self.workdir + "/.../..."

with

   self.scratch_file("...", "...")

which is more compact and portable


Looks much nicer, indeed, thanks for tackling it!

Reviewed-by: Thomas Huth <thuth@redhat.com>

[Prev in Thread]

Current Thread

[Next in Thread]

[PATCH v2 08/31] tests/functional: drop 'has_cmd' and 'has_cmds' helpers, (continued)
- [PATCH v2 08/31] tests/functional: drop 'has_cmd' and 'has_cmds' helpers, Daniel P . Berrangé, 2024/12/11
  - Re: [PATCH v2 08/31] tests/functional: drop 'has_cmd' and 'has_cmds' helpers, Thomas Huth, 2024/12/12
- [PATCH v2 10/31] tests/functional: switch over to using self.log_file(...), Daniel P . Berrangé, 2024/12/11
- [PATCH v2 11/31] tests/functional: switch over to using self.build_file(...), Daniel P . Berrangé, 2024/12/11
  - Re: [PATCH v2 11/31] tests/functional: switch over to using self.build_file(...), Thomas Huth, 2024/12/12
    - Re: [PATCH v2 11/31] tests/functional: switch over to using self.build_file(...), Daniel P . Berrangé, 2024/12/12
- [PATCH v2 12/31] tests/functional: switch over to using self.data_file(...), Daniel P . Berrangé, 2024/12/11
- [PATCH v2 14/31] tests/functional: switch over to using self.socket_dir(...), Daniel P . Berrangé, 2024/12/11
  - Re: [PATCH v2 14/31] tests/functional: switch over to using self.socket_dir(...), Thomas Huth, 2024/12/12
- [PATCH v2 13/31] tests/functional: switch over to using self.scratch_file(), Daniel P . Berrangé, 2024/12/11
  - Re: [PATCH v2 13/31] tests/functional: switch over to using self.scratch_file(), Thomas Huth <=
- [PATCH v2 15/31] tests/functional: remove redundant 'rmtree' call, Daniel P . Berrangé, 2024/12/11
- [PATCH v2 16/31] tests/functional: move archive handling into new archive.py file, Daniel P . Berrangé, 2024/12/11
  - Re: [PATCH v2 16/31] tests/functional: move archive handling into new archive.py file, Thomas Huth, 2024/12/12
- [PATCH v2 17/31] tests/functional: move uncompress handling into new uncompress.py file, Daniel P . Berrangé, 2024/12/11
  - Re: [PATCH v2 17/31] tests/functional: move uncompress handling into new uncompress.py file, Thomas Huth, 2024/12/12
- [PATCH v2 18/31] tests/functional: add common zip_extract helper, Daniel P . Berrangé, 2024/12/11
  - Re: [PATCH v2 18/31] tests/functional: add common zip_extract helper, Thomas Huth, 2024/12/12
- [PATCH v2 19/31] tests/functional: add common deb_extract helper, Daniel P . Berrangé, 2024/12/11
  - Re: [PATCH v2 19/31] tests/functional: add common deb_extract helper, Thomas Huth, 2024/12/12
- [PATCH v2 20/31] tests/functional: let cpio_extract accept filenames, Daniel P . Berrangé, 2024/12/11

Prev by Date: [PATCH 2/2] system: Restrict libpmem and libdaxctl CPPFLAGS to physmem.c
Next by Date: Re: [PATCH 19/26] rust: rename qemu-api modules to follow C code a bit more
Previous by thread: [PATCH v2 13/31] tests/functional: switch over to using self.scratch_file()
Next by thread: [PATCH v2 15/31] tests/functional: remove redundant 'rmtree' call
Index(es):
- Date
- Thread