[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v4 01/10] vfio/igd: fix GTT stolen memory size calculation for ge
From: |
Tomita Moeko |
Subject: |
[PATCH v4 01/10] vfio/igd: fix GTT stolen memory size calculation for gen 8+ |
Date: |
Fri, 6 Dec 2024 20:27:39 +0800 |
On gen 8 and later devices, the GTT stolen memory size when GGMS equals
0 is 0 (no preallocated memory) rather than 1MB [1].
[1] 3.1.13, 5th Generation Intel Core Processor Family Datasheet Vol. 2
https://www.intel.com/content/www/us/en/content-details/330835
Fixes: c4c45e943e51 ("vfio/pci: Intel graphics legacy mode assignment")
Reported-By: Alex Williamson <alex.williamson@redhat.com>
Signed-off-by: Tomita Moeko <tomitamoeko@gmail.com>
---
hw/vfio/igd.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/hw/vfio/igd.c b/hw/vfio/igd.c
index 4047f4f071..73ed1ec8e6 100644
--- a/hw/vfio/igd.c
+++ b/hw/vfio/igd.c
@@ -268,7 +268,7 @@ static int vfio_igd_gtt_max(VFIOPCIDevice *vdev)
gmch = vfio_pci_read_config(&vdev->pdev, IGD_GMCH, sizeof(gmch));
ggms = (gmch >> (gen < 8 ? 8 : 6)) & 0x3;
- if (gen > 6) {
+ if (gen > 6 && ggms != 0) {
ggms = 1 << ggms;
}
@@ -678,7 +678,7 @@ void vfio_probe_igd_bar4_quirk(VFIOPCIDevice *vdev, int nr)
/* Determine the size of stolen memory needed for GTT */
ggms_mb = (gmch >> (gen < 8 ? 8 : 6)) & 0x3;
- if (gen > 6) {
+ if (gen > 6 && ggms_mb != 0) {
ggms_mb = 1 << ggms_mb;
}
--
2.45.2
- [PATCH v4 00/10] vfio/igd: Enable legacy mode on more devices, Tomita Moeko, 2024/12/06
- [PATCH v4 01/10] vfio/igd: fix GTT stolen memory size calculation for gen 8+,
Tomita Moeko <=
- [PATCH v4 02/10] vfio/igd: remove unsupported device ids, Tomita Moeko, 2024/12/06
- [PATCH v4 03/10] vfio/igd: align generation with i915 kernel driver, Tomita Moeko, 2024/12/06
- [PATCH v4 04/10] vfio/igd: canonicalize memory size calculations, Tomita Moeko, 2024/12/06
- [PATCH v4 06/10] vfio/igd: add Alder/Raptor/Rocket/Ice/Jasper Lake device ids, Tomita Moeko, 2024/12/06
- [PATCH v4 05/10] vfio/igd: add Gemini Lake and Comet Lake device ids, Tomita Moeko, 2024/12/06
- [PATCH v4 08/10] vfio/igd: emulate GGC register in mmio bar0, Tomita Moeko, 2024/12/06
- [PATCH v4 07/10] vfio/igd: add macro for declaring mirrored registers, Tomita Moeko, 2024/12/06
- [PATCH v4 10/10] vfio/igd: add x-igd-gms option back to set DSM region size for guest, Tomita Moeko, 2024/12/06
- [PATCH v4 09/10] vfio/igd: emulate BDSM in mmio bar0 for gen 6-10 devices, Tomita Moeko, 2024/12/06
- Re: [PATCH v4 00/10] vfio/igd: Enable legacy mode on more devices, Cédric Le Goater, 2024/12/06