[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH V4 10/19] migration: cpr channel
|
From: |
Markus Armbruster |
|
Subject: |
Re: [PATCH V4 10/19] migration: cpr channel |
|
Date: |
Fri, 06 Dec 2024 10:31:46 +0100 |
|
User-agent: |
Gnus/5.13 (Gnus v5.13) |
Steven Sistare <steven.sistare@oracle.com> writes:
> On 12/5/2024 10:37 AM, Markus Armbruster wrote:
>> Steve Sistare <steven.sistare@oracle.com> writes:
>>
>>> Add the 'cpr' channel type, and stash the incoming cpr channel for use
>>> in a subsequent patch.
>>>
>>> Signed-off-by: Steve Sistare <steven.sistare@oracle.com>
>> [...]
>>
>>> diff --git a/qapi/migration.json b/qapi/migration.json
>>> index a605dc2..a26960b 100644
>>> --- a/qapi/migration.json
>>> +++ b/qapi/migration.json
>>> @@ -1578,11 +1578,12 @@
>>> # The migration channel-type request options.
>>> #
>>> # @main: Main outbound migration channel.
>>> +# @cpr: cpr state channel.
>>>
>> What does "cpr" stand for?
>
> docs/devel/migration/CPR.rst: CheckPoint and Restart (CPR)
Suggest something like
# The migration channel-type request options.
#
# @main: Main outbound migration channel.
#
# @cpr: Checkpoint and restart state channel
A quick glance at docs/devel/migration/CPR.rst makes me wonder: is that
really *developer* documentation?
Should we have something meant for *users*, too? QAPI docs could then
link to it.
- Re: [PATCH V4 02/19] physmem: fd-based shared memory, (continued)
[PATCH V4 08/19] hostmem-shm: preserve for cpr, Steve Sistare, 2024/12/02
[PATCH V4 12/19] migration: VMSTATE_FD, Steve Sistare, 2024/12/02
[PATCH V4 10/19] migration: cpr channel, Steve Sistare, 2024/12/02
[PATCH V4 11/19] migration: SCM_RIGHTS for QEMUFile, Steve Sistare, 2024/12/02
[PATCH V4 16/19] tests/qtest: defer connection, Steve Sistare, 2024/12/02
[PATCH V4 19/19] migration: cpr-transfer documentation, Steve Sistare, 2024/12/02