[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v2 5/7] migration/multifd: Remove sync processing on postcopy
From: |
Peter Xu |
Subject: |
[PATCH v2 5/7] migration/multifd: Remove sync processing on postcopy |
Date: |
Thu, 5 Dec 2024 19:58:32 -0500 |
Multifd never worked with postcopy, at least yet so far.
Remove the sync processing there, because it's confusing, and they should
never appear. Now if RAM_SAVE_FLAG_MULTIFD_FLUSH is observed, we fail hard
instead of trying to invoke multifd code.
Signed-off-by: Peter Xu <peterx@redhat.com>
---
migration/ram.c | 8 --------
1 file changed, 8 deletions(-)
diff --git a/migration/ram.c b/migration/ram.c
index 90811aabd4..154ff5abd4 100644
--- a/migration/ram.c
+++ b/migration/ram.c
@@ -3772,15 +3772,7 @@ int ram_load_postcopy(QEMUFile *f, int channel)
TARGET_PAGE_SIZE);
}
break;
- case RAM_SAVE_FLAG_MULTIFD_FLUSH:
- multifd_recv_sync_main();
- break;
case RAM_SAVE_FLAG_EOS:
- /* normal exit */
- if (migrate_multifd() &&
- migrate_multifd_flush_after_each_section()) {
- multifd_recv_sync_main();
- }
break;
default:
error_report("Unknown combination of migration flags: 0x%x"
--
2.47.0
- Re: [PATCH v2 3/7] migration/ram: Move RAM_SAVE_FLAG* into ram.h, (continued)
[PATCH v2 2/7] migration/multifd: Allow to sync with sender threads only, Peter Xu, 2024/12/05
[PATCH v2 4/7] migration/multifd: Unify RAM_SAVE_FLAG_MULTIFD_FLUSH messages, Peter Xu, 2024/12/05
[PATCH v2 5/7] migration/multifd: Remove sync processing on postcopy,
Peter Xu <=
[PATCH v2 6/7] migration/multifd: Cleanup src flushes on condition check, Peter Xu, 2024/12/05
[PATCH v2 7/7] migration/multifd: Document the reason to sync for save_setup(), Peter Xu, 2024/12/05