Re: [PATCH v3 2/2] hw/ide/ahci: Extract TYPE_SYSBUS_AHCI into dedicated file

[Philippe Mathieu-Daudé]

On 5/12/24 14:19, Bernhard Beschow wrote:
> Implement in dedicated file, just like TYPE_ICH9_AHCI.
>
> Signed-off-by: Bernhard Beschow <shentey@gmail.com>
> ---
>   hw/ide/ahci-sysbus.c | 91 ++++++++++++++++++++++++++++++++++++++++++++
>   hw/ide/ahci.c        | 67 --------------------------------
>   hw/arm/Kconfig       | 10 ++---
>   hw/ide/Kconfig       |  4 ++
>   hw/ide/meson.build   |  1 +
>   5 files changed, 101 insertions(+), 72 deletions(-)
>   create mode 100644 hw/ide/ahci-sysbus.c
>
> diff --git a/hw/ide/ahci-sysbus.c b/hw/ide/ahci-sysbus.c
> new file mode 100644
> index 0000000000..d43db0923f
> --- /dev/null
> +++ b/hw/ide/ahci-sysbus.c
> @@ -0,0 +1,91 @@
> +/*
> + * QEMU AHCI Emulation (MMIO-mapped devices)
> + *
> + * Copyright (c) 2010 qiaochong@loongson.cn
> + * Copyright (c) 2010 Roland Elek <elek.roland@gmail.com>
> + * Copyright (c) 2010 Sebastian Herbszt <herbszt@gmx.de>
> + * Copyright (c) 2010 Alexander Graf <agraf@suse.de>
> + *
> + * This library is free software; you can redistribute it and/or

Normally hw/ uses GPL, not LGPL, odd.

> + * modify it under the terms of the GNU Lesser General Public
> + * License as published by the Free Software Foundation; either
> + * version 2.1 of the License, or (at your option) any later version.
> + *
> + * This library is distributed in the hope that it will be useful,
> + * but WITHOUT ANY WARRANTY; without even the implied warranty of
> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
> + * Lesser General Public License for more details.
> + *
> + * You should have received a copy of the GNU Lesser General Public
> + * License along with this library; if not, see <http://www.gnu.org/licenses/>.
> + *
> + */