qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v2] tests/functional/aarch64: add tests for FEAT_RME


From: Pierrick Bouvier
Subject: Re: [PATCH v2] tests/functional/aarch64: add tests for FEAT_RME
Date: Mon, 2 Dec 2024 12:09:33 -0800
User-agent: Mozilla Thunderbird

On 12/2/24 11:56, Peter Maydell wrote:
On Mon, 2 Dec 2024 at 18:36, Pierrick Bouvier
<pierrick.bouvier@linaro.org> wrote:
Maybe our enable-debug should produced optimized builds by default, and
we could have a new --enable-debug-unopt for the "I need to use a
debugger" use case. Would save a lot of time for devs, and in CI where
minutes are precious.

The whole point of --enable-debug is "I might need to use a debugger"
(or a sanitizer, or anything else where you care about debug info).
If you want the optimized builds, that's the default.


It seems like we associate debug info to "I might need to use a debugger". But, it's not the only use case. Sanitizers for example, are usable with optimizations enabled as well (with some caveats, as some errors might be optimized out).

I don't have anything against what --enable-debug does, but supporting this for tests (and CI) because people *might* use it is a mistake IMHO.
It's an opinion beyond the current series use case.

It takes more time for devs and CI to run tests with debug build, compared to recompile and run test suites. And we hit timeouts and lose minutes because of that.

thanks
-- PMM




reply via email to

[Prev in Thread] Current Thread [Next in Thread]