[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] hw/input/ps2: Use ps2_raise_irq() instead of open coding it
From: |
Philippe Mathieu-Daudé |
Subject: |
Re: [PATCH] hw/input/ps2: Use ps2_raise_irq() instead of open coding it |
Date: |
Tue, 25 May 2021 09:48:22 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.10.1 |
ping? (patch reviewed)
On 5/13/21 7:12 PM, Philippe Mathieu-Daudé wrote:
> Inspired-by: Volker Rümelin <vr_qemu@t-online.de>
> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> ---
> hw/input/ps2.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/hw/input/ps2.c b/hw/input/ps2.c
> index 72cdb80ae1c..02d7e5da723 100644
> --- a/hw/input/ps2.c
> +++ b/hw/input/ps2.c
> @@ -213,7 +213,7 @@ void ps2_raise_irq(PS2State *s)
> void ps2_queue(PS2State *s, int b)
> {
> ps2_queue_noirq(s, b);
> - s->update_irq(s->update_arg, 1);
> + ps2_raise_irq(s);
> }
>
> void ps2_queue_2(PS2State *s, int b1, int b2)
> @@ -224,7 +224,7 @@ void ps2_queue_2(PS2State *s, int b1, int b2)
>
> ps2_queue_noirq(s, b1);
> ps2_queue_noirq(s, b2);
> - s->update_irq(s->update_arg, 1);
> + ps2_raise_irq(s);
> }
>
> void ps2_queue_3(PS2State *s, int b1, int b2, int b3)
> @@ -236,7 +236,7 @@ void ps2_queue_3(PS2State *s, int b1, int b2, int b3)
> ps2_queue_noirq(s, b1);
> ps2_queue_noirq(s, b2);
> ps2_queue_noirq(s, b3);
> - s->update_irq(s->update_arg, 1);
> + ps2_raise_irq(s);
> }
>
> void ps2_queue_4(PS2State *s, int b1, int b2, int b3, int b4)
> @@ -249,7 +249,7 @@ void ps2_queue_4(PS2State *s, int b1, int b2, int b3, int
> b4)
> ps2_queue_noirq(s, b2);
> ps2_queue_noirq(s, b3);
> ps2_queue_noirq(s, b4);
> - s->update_irq(s->update_arg, 1);
> + ps2_raise_irq(s);
> }
>
> /* keycode is the untranslated scancode in the current scancode set. */
>