[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH-for-6.0?] hw/rx/rx-gdbsim: Do not accept invalid memory size
From: |
Philippe Mathieu-Daudé |
Subject: |
Re: [PATCH-for-6.0?] hw/rx/rx-gdbsim: Do not accept invalid memory size |
Date: |
Sun, 2 May 2021 18:27:40 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 |
Hi Laurent, could you take this patch via your Trivial tree please?
On 4/8/21 12:30 AM, Philippe Mathieu-Daudé wrote:
> We check the amount of RAM is enough, warn when it is
> not, but if so we neglect to bail out. Fix that by
> adding the missing exit() call.
>
> Fixes: bda19d7bb56 ("hw/rx: Add RX GDB simulator")
> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> ---
> hw/rx/rx-gdbsim.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/hw/rx/rx-gdbsim.c b/hw/rx/rx-gdbsim.c
> index b1d7c2488ff..4e4ececae4b 100644
> --- a/hw/rx/rx-gdbsim.c
> +++ b/hw/rx/rx-gdbsim.c
> @@ -93,6 +93,7 @@ static void rx_gdbsim_init(MachineState *machine)
> char *sz = size_to_str(mc->default_ram_size);
> error_report("Invalid RAM size, should be more than %s", sz);
> g_free(sz);
> + exit(1);
> }
>
> /* Allocate memory space */
>
- Re: [PATCH-for-6.0?] hw/rx/rx-gdbsim: Do not accept invalid memory size,
Philippe Mathieu-Daudé <=