[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PULL v3 10/18] virtio-9p-device: fix memleak in virtio_9p_device_unreal
From: |
Michael S. Tsirkin |
Subject: |
[PULL v3 10/18] virtio-9p-device: fix memleak in virtio_9p_device_unrealize |
Date: |
Thu, 23 Jan 2020 02:10:38 -0500 |
From: Pan Nengyuan <address@hidden>
v->vq forgot to cleanup in virtio_9p_device_unrealize, the memory leak
stack is as follow:
Direct leak of 14336 byte(s) in 2 object(s) allocated from:
#0 0x7f819ae43970 (/lib64/libasan.so.5+0xef970) ??:?
#1 0x7f819872f49d (/lib64/libglib-2.0.so.0+0x5249d) ??:?
#2 0x55a3a58da624 (./x86_64-softmmu/qemu-system-x86_64+0x2c14624)
/mnt/sdb/qemu/hw/virtio/virtio.c:2327
#3 0x55a3a571bac7 (./x86_64-softmmu/qemu-system-x86_64+0x2a55ac7)
/mnt/sdb/qemu/hw/9pfs/virtio-9p-device.c:209
#4 0x55a3a58e7bc6 (./x86_64-softmmu/qemu-system-x86_64+0x2c21bc6)
/mnt/sdb/qemu/hw/virtio/virtio.c:3504
#5 0x55a3a5ebfb37 (./x86_64-softmmu/qemu-system-x86_64+0x31f9b37)
/mnt/sdb/qemu/hw/core/qdev.c:876
Reported-by: Euler Robot <address@hidden>
Signed-off-by: Pan Nengyuan <address@hidden>
Message-Id: <address@hidden>
Reviewed-by: Michael S. Tsirkin <address@hidden>
Signed-off-by: Michael S. Tsirkin <address@hidden>
Reviewed-by: Christian Schoenebeck <address@hidden>
Acked-by: Greg Kurz <address@hidden>
---
hw/9pfs/virtio-9p-device.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/hw/9pfs/virtio-9p-device.c b/hw/9pfs/virtio-9p-device.c
index 991e175c82..ba35892940 100644
--- a/hw/9pfs/virtio-9p-device.c
+++ b/hw/9pfs/virtio-9p-device.c
@@ -218,6 +218,7 @@ static void virtio_9p_device_unrealize(DeviceState *dev,
Error **errp)
V9fsVirtioState *v = VIRTIO_9P(dev);
V9fsState *s = &v->state;
+ virtio_del_queue(vdev, 0);
virtio_cleanup(vdev);
v9fs_device_unrealize_common(s, errp);
}
--
MST
- [PULL v3 00/18] virtio, pc: fixes, features, Michael S. Tsirkin, 2020/01/23
- [PULL v3 01/18] q35: implement 128K SMRAM at default SMBASE address, Michael S. Tsirkin, 2020/01/23
- [PULL v3 03/18] acpi: cpuhp: spec: clarify 'CPU selector' register usage and endianness, Michael S. Tsirkin, 2020/01/23
- [PULL v3 02/18] tests: q35: MCH: add default SMBASE SMRAM lock test, Michael S. Tsirkin, 2020/01/23
- [PULL v3 04/18] acpi: cpuhp: spec: fix 'Command data' description, Michael S. Tsirkin, 2020/01/23
- [PULL v3 05/18] acpi: cpuhp: spec: clarify store into 'Command data' when 'Command field' == 0, Michael S. Tsirkin, 2020/01/23
- [PULL v3 06/18] acpi: cpuhp: introduce 'Command data 2' field, Michael S. Tsirkin, 2020/01/23
- [PULL v3 07/18] acpi: cpuhp: spec: add typical usecases, Michael S. Tsirkin, 2020/01/23
- [PULL v3 09/18] bios-tables-test: document expected file update, Michael S. Tsirkin, 2020/01/23
- [PULL v3 10/18] virtio-9p-device: fix memleak in virtio_9p_device_unrealize,
Michael S. Tsirkin <=
- [PULL v3 11/18] virtio-9p-device: convert to new virtio_delete_queue, Michael S. Tsirkin, 2020/01/23
- [PULL v3 12/18] virtio-scsi: delete vqs in unrealize to avoid memleaks, Michael S. Tsirkin, 2020/01/23
- [PULL v3 13/18] virtio-scsi: convert to new virtio_delete_queue, Michael S. Tsirkin, 2020/01/23
- [PULL v3 14/18] vhost-vsock: delete vqs in vhost_vsock_unrealize to avoid memleaks, Michael S. Tsirkin, 2020/01/23
- [PULL v3 15/18] vhost: Add names to section rounded warning, Michael S. Tsirkin, 2020/01/23
- [PULL v3 16/18] vhost: Only align sections for vhost-user, Michael S. Tsirkin, 2020/01/23
- [PULL v3 17/18] i386:acpi: Remove _HID from the SMBus ACPI entry, Michael S. Tsirkin, 2020/01/23
- [PULL v3 18/18] vhost: coding style fix, Michael S. Tsirkin, 2020/01/23
- [PULL v3 08/18] acpi: cpuhp: add CPHP_GET_CPU_ID_CMD command, Michael S. Tsirkin, 2020/01/23