[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 1/5] hw/mips/malta: Fix the DEBUG_BOARD_INIT cod
From: |
Markus Armbruster |
Subject: |
Re: [Qemu-devel] [PATCH 1/5] hw/mips/malta: Fix the DEBUG_BOARD_INIT code |
Date: |
Thu, 07 Mar 2019 08:06:13 +0100 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) |
Philippe Mathieu-Daudé <address@hidden> writes:
> Commit fa1d36df746 missed to convert this ifdef'ed out code.
> Introduce the pflash_blk variable.
>
> This fixes:
>
> hw/mips/mips_malta.c:1273:16: error: implicit declaration of function
> ‘blk_name’; did you mean ‘basename’? [-Werror=implicit-function-declaration]
> blk_name(dinfo->bdrv), fl_sectors);
> ^~~~~~~~
> hw/mips/mips_malta.c:1273:16: error: nested extern declaration of
> ‘blk_name’ [-Werror=nested-externs]
> hw/mips/mips_malta.c:1273:30: error: ‘DriveInfo’ {aka ‘struct DriveInfo’}
> has no member named ‘bdrv’
> blk_name(dinfo->bdrv), fl_sectors);
> ^~
>
> Fixes: fa1d36df746
> Signed-off-by: Philippe Mathieu-Daudé <address@hidden>
Question for the maintainers: Aurelien, Aleksandar, fix the
DEBUG_BOARD_INIT code or drop it? It looks rather stale...
- [Qemu-devel] [PATCH 0/5] mips_malta: Clean up definition of flash memory size, Philippe Mathieu-Daudé, 2019/03/05
- [Qemu-devel] [PATCH 2/5] hw/mips/malta: Remove fl_sectors variable (used one single time), Philippe Mathieu-Daudé, 2019/03/05
- [Qemu-devel] [PATCH 3/5] hw/mips/malta: Restrict 'bios_size' variable scope, Philippe Mathieu-Daudé, 2019/03/05
- [Qemu-devel] [PATCH 4/5] hw/mips/malta: Only accept 'monitor' pflash of 4MiB, Philippe Mathieu-Daudé, 2019/03/05
- [Qemu-devel] [PATCH 5/5] mips_malta: Clean up definition of flash memory size somewhat, Philippe Mathieu-Daudé, 2019/03/05