[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 11/23] hyperv: address HvSintRoute by X86CPU poi
|
From: |
Paolo Bonzini |
|
Subject: |
Re: [Qemu-devel] [PATCH 11/23] hyperv: address HvSintRoute by X86CPU pointer |
|
Date: |
Wed, 14 Jun 2017 14:17:44 +0200 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.1.0 |
On 14/06/2017 14:14, Roman Kagan wrote:
>>> vcpu_id risks being confused KVM's vcpu_id (which is the CPU APIC
>>> ID in x86). If you are already touching this code, this could be
>>> renamed to vp_index to avoid confusion.
>> Actually the VP_INDEX is _also_ the vcpu_id. Should we just document
>> that KVM makes the VP_INDEX equal to the CPU APIC id, and adjust patch 5
>> accordingly?
> I think here it makes sense to follow Eduardo's suggestion because this
> code doesn't need to know how VP_INDEX is defined.
Yes, I agree. Sorry if that wasn't clear---Eduardo's comment just made
me notice this possible solution to the issue of patch 5.
Paolo
> The real matter is discussed in patch 5, yes.
- [Qemu-devel] [PATCH 21/23] hyperv_testdev: add SynIC message and event testmodes, (continued)
[Qemu-devel] [PATCH 23/23] hyperv: update copyright notices, Roman Kagan, 2017/06/06
Message not available