[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH for-2.9 45/47] qapi: Drop unused .check_clash()
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH for-2.9 45/47] qapi: Drop unused .check_clash() parameter schema |
Date: |
Tue, 14 Mar 2017 20:46:03 -0500 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 |
On 03/13/2017 01:18 AM, Markus Armbruster wrote:
> Signed-off-by: Markus Armbruster <address@hidden>
> ---
> scripts/qapi.py | 10 +++++-----
> 1 file changed, 5 insertions(+), 5 deletions(-)
I'm not sure now why the 'schema' parameter was introduced; looks like
it was in commit b807a1e and unused there. I think at one point in my
multitude of refactoring patches that I was using schema for a name
lookup for nicer error reporting, but that idea fell by the wayside over
several revisions, and the 'schema' parameter became unused without
either of us realizing it.
At any rate, the cleanup is sane.
Reviewed-by: Eric Blake <address@hidden>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
- Re: [Qemu-devel] [PATCH for-2.9 37/47] qapi: Fix detection of bogus member documentation, (continued)
- [Qemu-devel] [PATCH for-2.9 03/47] qapi: Back out doc comments added just to please qapi.py, Markus Armbruster, 2017/03/13
- [Qemu-devel] [PATCH for-2.9 42/47] qapi: enum_types is a list used like a dict, make it one, Markus Armbruster, 2017/03/13
- [Qemu-devel] [PATCH for-2.9 45/47] qapi: Drop unused .check_clash() parameter schema, Markus Armbruster, 2017/03/13
- Re: [Qemu-devel] [PATCH for-2.9 45/47] qapi: Drop unused .check_clash() parameter schema,
Eric Blake <=
- [Qemu-devel] [PATCH for-2.9 36/47] tests/qapi-schema: Improve coverage of bogus member docs, Markus Armbruster, 2017/03/13
- Re: [Qemu-devel] [PATCH for-2.9 00/47] qapi: Put type information back into QMP documentation, Marc-André Lureau, 2017/03/13
- Re: [Qemu-devel] [PATCH for-2.9 00/47] qapi: Put type information back into QMP documentation, Markus Armbruster, 2017/03/13
- Re: [Qemu-devel] [PATCH for-2.9 00/47] qapi: Put type information back into QMP documentation, Marc-André Lureau, 2017/03/13
- Re: [Qemu-devel] [PATCH for-2.9 00/47] qapi: Put type information back into QMP documentation, Markus Armbruster, 2017/03/13
- Re: [Qemu-devel] [PATCH for-2.9 00/47] qapi: Put type information back into QMP documentation, Marc-André Lureau, 2017/03/14
- Re: [Qemu-devel] [PATCH for-2.9 00/47] qapi: Put type information back into QMP documentation, Markus Armbruster, 2017/03/14
- Re: [Qemu-devel] [PATCH for-2.9 00/47] qapi: Put type information back into QMP documentation, Marc-André Lureau, 2017/03/15
Re: [Qemu-devel] [PATCH for-2.9 00/47] qapi: Put type information back into QMP documentation, Marc-André Lureau, 2017/03/14