qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v2 6/8] dump-query: implement "status" of "dump-


From: Paolo Bonzini
Subject: Re: [Qemu-devel] [PATCH v2 6/8] dump-query: implement "status" of "dump-query" command.
Date: Fri, 27 Nov 2015 12:53:21 +0100
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0


On 27/11/2015 12:42, Peter Xu wrote:
> > As mentioned early, you can use an enum.  QEMU usually prints enums in
> > lowercase and separates words with "-".  Similar to MigrationStatus you
> > can use none, active, completed, failed.  In fact you might even reuse
> > MigrationStatus directly, it's simpler.
> 
> I think it might be a little big confusing if I use MigrationStatus
> directly. I can define a enum. 

Sure, that's fine.  Though there is more than a little similarity
between migration and dump...  (essentially, migration is a dump with a
custom format and with additional support for storing device state).

Paolo



reply via email to

[Prev in Thread] Current Thread [Next in Thread]