Re: [Qemu-devel] [PATCH v2 2/8] target-i386: x87 exception pointers using TCG.

[Jaume Martí]

Hello,

I thought that it was more readable with 2 boolean arguments, but I will encode them into a single argument. Also, on fxsave and fxrstor helpers I will encode the data32 and data64 parmeters into a single one.

Best regards,

Jaume

On Sat, Aug 30, 2014 at 12:57 AM, Richard Henderson <address@hidden> wrote:

On 08/28/2014 01:44 PM, Jaume Marti Farriol wrote:

> -void helper_fstenv(CPUX86State *env, target_ulong ptr, int data32)
> +void helper_fstenv(CPUX86State *env, target_ulong ptr, int data32,
> +                   int protected_mode)

You ought not need two arguments here.  All of the formats are mutually
exclusive, so can be encoded into a single argument, replacing data32.


r~