[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v1 1/5] intc/xilinx_intc: Use qemu_set_irq
From: |
Peter Crosthwaite |
Subject: |
Re: [Qemu-devel] [PATCH v1 1/5] intc/xilinx_intc: Use qemu_set_irq |
Date: |
Fri, 7 Jun 2013 12:39:39 +1000 |
email accidentally sent with cc supression, so cc qemu-trivial as intended.
On Fri, Jun 7, 2013 at 12:38 PM, <address@hidden> wrote:
> From: Peter Crosthwaite <address@hidden>
>
> Use qemu_set_irq rather than if-elsing qemu_irq_(lower|raise). No
> functional change, just reduces verbosity.
>
> Cc: address@hidden
>
> Signed-off-by: Peter Crosthwaite <address@hidden>
> ---
>
> hw/intc/xilinx_intc.c | 6 +-----
> 1 file changed, 1 insertion(+), 5 deletions(-)
>
> diff --git a/hw/intc/xilinx_intc.c b/hw/intc/xilinx_intc.c
> index b106e72..5df7008 100644
> --- a/hw/intc/xilinx_intc.c
> +++ b/hw/intc/xilinx_intc.c
> @@ -66,11 +66,7 @@ static void update_irq(struct xlx_pic *p)
> i = ~0;
>
> p->regs[R_IVR] = i;
> - if ((p->regs[R_MER] & 1) && p->regs[R_IPR]) {
> - qemu_irq_raise(p->parent_irq);
> - } else {
> - qemu_irq_lower(p->parent_irq);
> - }
> + qemu_set_irq(p->parent_irq, (p->regs[R_MER] & 1) && p->regs[R_IPR]);
> }
>
> static uint64_t
> --
> 1.8.3.rc1.44.gb387c77.dirty
>
[Qemu-devel] [PATCH v1 2/5] intc/xilinx_intc: Don't clear level sens. IRQs without ACK, peter . crosthwaite, 2013/06/06
[Qemu-devel] [PATCH v1 3/5] intc/xilinx_intc: Handle level interrupt retriggering, peter . crosthwaite, 2013/06/06
[Qemu-devel] [PATCH v1 4/5] intc/xilinx_intc: Inhibit write to ISR when HIE, peter . crosthwaite, 2013/06/06
[Qemu-devel] [PATCH v1 5/5] intc/xilinx_intc: Dont lower IRQ when HIE cleared, peter . crosthwaite, 2013/06/06