[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] softfloat: export float32_nan and float32_infin
From: |
Peter Maydell |
Subject: |
Re: [Qemu-devel] [PATCH] softfloat: export float32_nan and float32_infinity. |
Date: |
Wed, 16 Feb 2011 11:53:49 +0000 |
On 14 February 2011 16:47, Christophe Lyon <address@hidden> wrote:
>
> These two special values are needed to implement some helper functions, which
> return these values in some cases.
I assume this is for vrecpe, right? I think it would be better
to post this as part of that patchset; it's easier to see the
rationale for adding the functions when you also have the
code that's using them.
>
> /*----------------------------------------------------------------------------
> +| Returns the default NaN.
> +*----------------------------------------------------------------------------*/
> +
> +float32 float32_nan(void)
> +{
> + return float32_default_nan;
> +}
Maybe we should just expose float32_default_nan in
softfloat.h somehow; that would match float32_zero,
float32_one, etc (ie it would not be a function).
> +#define float32_infinity make_float32(0x7f800000)
No objection to this one.
-- PMM