[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] Re: [PATCH] pci: introduce get_info_quirk callback.
From: |
Isaku Yamahata |
Subject: |
[Qemu-devel] Re: [PATCH] pci: introduce get_info_quirk callback. |
Date: |
Fri, 12 Feb 2010 22:34:34 +0900 |
User-agent: |
Mutt/1.5.19 (2009-01-05) |
On Fri, Feb 12, 2010 at 02:54:59PM +0200, Michael S. Tsirkin wrote:
> On Fri, Feb 12, 2010 at 11:31:34AM +0900, Isaku Yamahata wrote:
> > This patch fixes 525e05147d5a3bdc08caa422d108c1ef71b584b5
> > by introducing device specific get_info_quirk callback.
> > It wrongly assumes that pci host bridge class device has
> > header type of pci-pci bridge. But this isn't always true.
> > In fact i440fx pci host bridge has header type of normal device,
> > hence it breaks i440fx and other pci host bridges.
> > The right fix is that header type should be checked, instead of device
> > class.
> >
> > The change set's purpose is to show PBM pci host bridge
> > info which doesn't conform to PCI specification.
>
> So, PBM has header type PCI_HEADER_TYPE_NORMAL
> but all config space is in bridge format?
Some of registers is in bridge format.
To be honest, I don't know whether all or some.
Blue seems to want bus numbers registers at least.
http://lists.gnu.org/archive/html/qemu-devel/2010-02/msg00519.html
--
yamahata