[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] arm, mips and mipsel broken
From: |
Aurelien Jarno |
Subject: |
[Qemu-devel] arm, mips and mipsel broken |
Date: |
Tue, 10 Nov 2009 21:50:40 +0100 |
User-agent: |
Mutt/1.5.18 (2008-05-17) |
Please note that at least qemu-system-arm, qemu-system-mips and
qemu-system-mipsel are broken by this commit:
commit c169998802505c244b8bcad562633f29de7d74a4
Author: Glauber Costa <address@hidden>
Date: Thu Nov 5 16:05:15 2009 -0200
v3: don't call reset functions on cpu initialization
There is absolutely no need to call reset functions when initializing
devices. Since we are already registering them, calling qemu_system_reset()
should suffice. Actually, it is what happens when we reboot the machine,
and using the same process instead of a special case semantics will even
allow us to find bugs easier.
Furthermore, the fact that we initialize things like the cpu quite early,
leads to the need to introduce synchronization stuff like qemu_system_cond.
This patch removes it entirely. All we need to do is call
qemu_system_reset()
only when we're already sure the system is up and running
I tested it with qemu (with and without io-thread) and qemu-kvm, and it
seems to be doing okay - although qemu-kvm uses a slightly different patch.
[ v2: user mode still needs cpu_reset, so put it in ifdef. ]
[ v3: leave qemu_system_cond for now. ]
Signed-off-by: Glauber Costa <address@hidden>
Signed-off-by: Blue Swirl <address@hidden>
--
Aurelien Jarno GPG: 1024D/F1BCDB73
address@hidden http://www.aurel32.net
- [Qemu-devel] arm, mips and mipsel broken,
Aurelien Jarno <=
- Message not available
Re: [Qemu-devel] arm, mips and mipsel broken, Glauber Costa, 2009/11/11
Re: [Qemu-devel] arm, mips and mipsel broken, Stefan Weil, 2009/11/12