Re: [Qemu-devel] [PATCH 9/9] Move mp_state to CPU_COMMON

[Alexander Graf]

On 09.11.2009, at 20:44, Anthony Liguori wrote:

> Alexander Graf wrote:
> > On 29.10.2009, at 22:39, Hollis Blanchard wrote:
> >
> > > On Wed, 2009-10-21 at 21:17 +0200, Alexander Graf wrote:
> > > > MP State is implemented in the generic code, so let's move the  
> > > > variable
> > > > it accesses to generic code as well.
> > > >
> > > > Still unbreaks PPC and now even S390x w/ KVM.
> > > >
> > > > Signed-off-by: Alexander Graf <address@hidden>
> > >
> > > Acked-by: Hollis Blanchard <address@hidden>
> > >
> > > Anthony, this patch fixes a build break in PowerPC KVM. Arguably it
> > > should not be patch 9/9 in an S390 series, but in any case please  
> > > apply
> > > it. :)
> >
> > Anthony, could you please apply it? Not having S390 support is  
> > pitiful, but having PPC break too is even worse!
>
> mp_state does not belong in CPU_COMMON.

So you'd rather like a patch #ifdef'ing out the mp code to x86 only?  
Or move it to target-i386/kvm.c?

Alex