Re: [Qemu-devel] [PATCH] pcnet32 driver change, please test

[Thiemo Seufer]

Fabrice Bellard wrote:
> Thiemo Seufer wrote:
> >Thiemo Seufer wrote:
> >>Hello All,
> >>
> >>I changed the pcnet32 driver to get rid of bitfields in its
> >>implementation, now it works also on big endian host systems.
> >>
> >>I tested only the 32 bit mode which is used by MIPS/Malta, and
> >>I'm not sure if it still works in Lance mode (as e.g. used on SPARC).
> >>So please test if it still works.
> >
> >I forgot to delete a line of debug output, updated.
> 
> It seems that you made some unnecessary changes (why did you changed the 
> code in pcnet_init ?).

That code currently accesses initblk members (padr. ladrf) after the
initblk structure went out of scope. I also wanted to keep the data
acquisition with its byte swaps in the same place.


Thiemo.