qemu-block
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] iotests/pylintrc: allow up to 10 similar lines


From: Vladimir Sementsov-Ogievskiy
Subject: Re: [PATCH] iotests/pylintrc: allow up to 10 similar lines
Date: Tue, 28 May 2024 15:49:21 +0300
User-agent: Mozilla Thunderbird

On 30.04.24 12:13, Vladimir Sementsov-Ogievskiy wrote:
We want to have similar QMP objects in different tests. Reworking these
objects to make common parts by calling some helper functions doesn't
seem good. It's a lot more comfortable to see the whole QAPI request in
one place.

So, let's increase the limit, to unblock further commit
"iotests: add backup-discard-source"

Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@yandex-team.ru>
---

Hi all! That's a patch to unblock my PR
"[PULL 0/6] Block jobs patches for 2024-04-29"
   <20240429115157.2260885-1-vsementsov@yandex-team.ru>
   https://patchew.org/QEMU/20240429115157.2260885-1-vsementsov@yandex-team.ru/


  tests/qemu-iotests/pylintrc | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tests/qemu-iotests/pylintrc b/tests/qemu-iotests/pylintrc
index de2e0c2781..05b75ee59b 100644
--- a/tests/qemu-iotests/pylintrc
+++ b/tests/qemu-iotests/pylintrc
@@ -55,4 +55,4 @@ max-line-length=79
[SIMILARITIES] -min-similarity-lines=6
+min-similarity-lines=10


Hi! I hope it's OK, if I just apply this to my block branch, and resend "[PULL 0/6] 
Block jobs patches for 2024-04-29" which is blocked on this problem.

Thanks for reviewing,
applied to my block branch

--
Best regards,
Vladimir




reply via email to

[Prev in Thread] Current Thread [Next in Thread]