[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v2 18/18] block: Remove remaining unused symbols in coroutines.h
From: |
Alberto Faria |
Subject: |
[PATCH v2 18/18] block: Remove remaining unused symbols in coroutines.h |
Date: |
Tue, 5 Jul 2022 17:15:26 +0100 |
Some can be made static, others are unused generated_co_wrappers.
Signed-off-by: Alberto Faria <afaria@redhat.com>
Reviewed-by: Paolo Bonzini <pbonzini@redhat.com>
Reviewed-by: Hanna Reitz <hreitz@redhat.com>
---
block/block-backend.c | 6 +++---
block/coroutines.h | 19 -------------------
2 files changed, 3 insertions(+), 22 deletions(-)
diff --git a/block/block-backend.c b/block/block-backend.c
index 920ba0dd1f..bf63f187ef 100644
--- a/block/block-backend.c
+++ b/block/block-backend.c
@@ -1358,7 +1358,7 @@ int coroutine_fn blk_co_preadv_part(BlockBackend *blk,
int64_t offset,
}
/* To be called between exactly one pair of blk_inc/dec_in_flight() */
-int coroutine_fn
+static int coroutine_fn
blk_co_do_pwritev_part(BlockBackend *blk, int64_t offset, int64_t bytes,
QEMUIOVector *qiov, size_t qiov_offset,
BdrvRequestFlags flags)
@@ -1691,7 +1691,7 @@ BlockAIOCB *blk_aio_ioctl(BlockBackend *blk, unsigned
long int req, void *buf,
}
/* To be called between exactly one pair of blk_inc/dec_in_flight() */
-int coroutine_fn
+static int coroutine_fn
blk_co_do_pdiscard(BlockBackend *blk, int64_t offset, int64_t bytes)
{
int ret;
@@ -1739,7 +1739,7 @@ int coroutine_fn blk_co_pdiscard(BlockBackend *blk,
int64_t offset,
}
/* To be called between exactly one pair of blk_inc/dec_in_flight() */
-int coroutine_fn blk_co_do_flush(BlockBackend *blk)
+static int coroutine_fn blk_co_do_flush(BlockBackend *blk)
{
blk_wait_while_drained(blk);
IO_CODE();
diff --git a/block/coroutines.h b/block/coroutines.h
index d66551a277..3a2bad564f 100644
--- a/block/coroutines.h
+++ b/block/coroutines.h
@@ -63,17 +63,6 @@ nbd_co_do_establish_connection(BlockDriverState *bs, bool
blocking,
Error **errp);
-int coroutine_fn
-blk_co_do_pwritev_part(BlockBackend *blk, int64_t offset, int64_t bytes,
- QEMUIOVector *qiov, size_t qiov_offset,
- BdrvRequestFlags flags);
-
-int coroutine_fn
-blk_co_do_pdiscard(BlockBackend *blk, int64_t offset, int64_t bytes);
-
-int coroutine_fn blk_co_do_flush(BlockBackend *blk);
-
-
/*
* "I/O or GS" API functions. These functions can run without
* the BQL, but only in one specific iothread/main loop.
@@ -82,14 +71,6 @@ int coroutine_fn blk_co_do_flush(BlockBackend *blk);
* the "I/O or GS" API.
*/
-int generated_co_wrapper
-bdrv_preadv(BdrvChild *child, int64_t offset, int64_t bytes,
- QEMUIOVector *qiov, BdrvRequestFlags flags);
-
-int generated_co_wrapper
-bdrv_pwritev(BdrvChild *child, int64_t offset, int64_t bytes,
- QEMUIOVector *qiov, BdrvRequestFlags flags);
-
int generated_co_wrapper
bdrv_common_block_status_above(BlockDriverState *bs,
BlockDriverState *base,
--
2.36.1
- [PATCH v2 10/18] block: Change blk_pwrite_compressed() param order, (continued)
- [PATCH v2 10/18] block: Change blk_pwrite_compressed() param order, Alberto Faria, 2022/07/05
- [PATCH v2 08/18] block: Add blk_[co_]preadv_part(), Alberto Faria, 2022/07/05
- [PATCH v2 11/18] block: Add blk_co_pwrite_compressed(), Alberto Faria, 2022/07/05
- [PATCH v2 12/18] block: Implement blk_pwrite_zeroes() using generated_co_wrapper, Alberto Faria, 2022/07/05
- [PATCH v2 13/18] block: Implement blk_pdiscard() using generated_co_wrapper, Alberto Faria, 2022/07/05
- [PATCH v2 14/18] block: Implement blk_flush() using generated_co_wrapper, Alberto Faria, 2022/07/05
- [PATCH v2 17/18] block: Reorganize some declarations in block-backend-io.h, Alberto Faria, 2022/07/05
- [PATCH v2 15/18] block: Add blk_co_ioctl(), Alberto Faria, 2022/07/05
- [PATCH v2 16/18] block: Add blk_co_truncate(), Alberto Faria, 2022/07/05
- [PATCH v2 18/18] block: Remove remaining unused symbols in coroutines.h,
Alberto Faria <=
- Re: [PATCH v2 00/18] Make block-backend-io.h API more consistent, Hanna Reitz, 2022/07/06