Re: [Qemu-block] [Qemu-devel] [PATCH v2 1/6] qapi: Support features for structs

[Eric Blake]

On 5/24/19 8:20 AM, Markus Armbruster wrote:
> "Support features for structs" accidentally fits the "Do stuff"
> commit message anti-pattern.  Suggest:
> 
>     qapi: Add feature flags to struct types
> 

>> +# @features: names of features that are supported by this version and build 
>> and
>> +#            aren't othervise visible through schema introspection (e.g. 
>> change

s/othervise/otherwise/

>> +#            of behaviour related to an object type that didn't come with a

Do we have a strong US or UK preference on spelling in user-visible
docs? (US would use "behavior")

>> +#            syntactic change in the schema of the object type) (since: 4.1)
>> +#
> 
> Specify "in no particular order", like we do elsewhere.
> 
> Let's wrap lines a little earlier.
-- 
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3226
Virtualization:  qemu.org | libvirt.org

signature.asc
Description: OpenPGP digital signature