Re: [Qemu-block] [PATCH 10/17] vdi: Implement .bdrv_co_pwritev() interface

[Kevin Wolf]

Am 27.04.2016 um 16:17 hat Stefan Hajnoczi geschrieben:
> On Wed, Apr 27, 2016 at 11:52:40AM +0200, Kevin Wolf wrote:
> > @@ -703,6 +712,7 @@ static int vdi_co_write(BlockDriverState *bs,
> >          VdiHeader *header = (VdiHeader *) block;
> >          uint8_t *base;
> >          uint64_t offset;
> > +        uint32_t n_sectors;
> >  
> >          logout("now writing modified header\n");
> >          assert(VDI_IS_ALLOCATED(bmap_first));
> 
> Unnecessary change?

No, I removed a top-level n_sectors declaration because I wanted the
compiler to complain about any uses in the main part, which should be
byte-aligned now. This final block still uses some sector arithmetics,
though, and therefore needs to reintroduce the variable.

Kevin

pgpD55ikJRiFl.pgp
Description: PGP signature