[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] hw/misc: cast nand_getio value to uint64_t
|
From: |
Alex Bennée |
|
Subject: |
Re: [PATCH] hw/misc: cast nand_getio value to uint64_t |
|
Date: |
Thu, 26 Dec 2024 22:49:25 +0000 |
|
User-agent: |
mu4e 1.12.8; emacs 29.4 |
Tigran Sogomonian <tsogomonian@astralinux.ru> writes:
> s->buswidth = nand_flash_ids[s->chip_id].width >> 3;
> <= 16 >> 3 <= 2.
> x <= s->ioaddr[offset] << (s->buswidth << 3)
> <= max_uint8_t << 16
> With x << 24 overflow is possible.
> Other cases are similar.
> Thus, need to cast return value to uint64_t.
>
> Found by Linux Verification Center (linuxtesting.org) with SVACE.
>
> Signed-off-by: Tigran Sogomonian <tsogomonian@astralinux.ru>
This code was removed in 192f75ad11 (hw/misc: Remove omap_gpmc)
--
Alex Bennée
Virtualisation Tech Lead @ Linaro