Re: [PATCH v3 5/7] hw/sd/aspeed_sdhci: Add AST2700 Support

[Cédric Le Goater]

On 12/4/24 09:05, Jamin Lin wrote:
> Introduce a new ast2700 class to support AST2700. Add a new ast2700 SDHCI class
> init function and set the value of capability register to "0x0000000719f80080".
>
> Signed-off-by: Jamin Lin <jamin_lin@aspeedtech.com>


Reviewed-by: Cédric Le Goater <clg@redhat.com>

Thanks,

C.


> ---
>   hw/sd/aspeed_sdhci.c         | 16 ++++++++++++++--
>   include/hw/sd/aspeed_sdhci.h |  1 +
>   2 files changed, 15 insertions(+), 2 deletions(-)
>
> diff --git a/hw/sd/aspeed_sdhci.c b/hw/sd/aspeed_sdhci.c
> index 4e64e2537a..de92f84111 100644
> --- a/hw/sd/aspeed_sdhci.c
> +++ b/hw/sd/aspeed_sdhci.c
> @@ -239,6 +239,15 @@ static void aspeed_2600_sdhci_class_init(ObjectClass 
> *klass, void *data)
>       asc->capareg = 0x0000000701f80080;
>   }
>   
> +static void aspeed_2700_sdhci_class_init(ObjectClass *klass, void *data)
> +{
> +    DeviceClass *dc = DEVICE_CLASS(klass);
> +    AspeedSDHCIClass *asc = ASPEED_SDHCI_CLASS(klass);
> +
> +    dc->desc = "ASPEED 2700 SDHCI Controller";
> +    asc->capareg = 0x0000000719f80080;
> +}
> +
>   static const TypeInfo aspeed_sdhci_types[] = {
>       {
>           .name           = TYPE_ASPEED_SDHCI,
> @@ -263,8 +272,11 @@ static const TypeInfo aspeed_sdhci_types[] = {
>           .parent = TYPE_ASPEED_SDHCI,
>           .class_init = aspeed_2600_sdhci_class_init,
>       },
> +    {
> +        .name = TYPE_ASPEED_2700_SDHCI,
> +        .parent = TYPE_ASPEED_SDHCI,
> +        .class_init = aspeed_2700_sdhci_class_init,
> +    },
>   };
>   
>   DEFINE_TYPES(aspeed_sdhci_types)
> -
> -
> diff --git a/include/hw/sd/aspeed_sdhci.h b/include/hw/sd/aspeed_sdhci.h
> index 8083797e25..4ef1770471 100644
> --- a/include/hw/sd/aspeed_sdhci.h
> +++ b/include/hw/sd/aspeed_sdhci.h
> @@ -16,6 +16,7 @@
>   #define TYPE_ASPEED_2400_SDHCI TYPE_ASPEED_SDHCI "-ast2400"
>   #define TYPE_ASPEED_2500_SDHCI TYPE_ASPEED_SDHCI "-ast2500"
>   #define TYPE_ASPEED_2600_SDHCI TYPE_ASPEED_SDHCI "-ast2600"
> +#define TYPE_ASPEED_2700_SDHCI TYPE_ASPEED_SDHCI "-ast2700"
>   OBJECT_DECLARE_TYPE(AspeedSDHCIState, AspeedSDHCIClass, ASPEED_SDHCI)
>   
>   #define ASPEED_SDHCI_NUM_SLOTS    2