[Pspp-commits] [SCM] GNU PSPP branch, master, updated. v0.6.1-2003-gb84ba63

[Ben Pfaff]

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "GNU PSPP".

The branch, master has been updated
       via  b84ba63c22f65fffebf1dec32a982be2d5a83536 (commit)
       via  de8fc417b1268addaa8b65f7be78c80c61bc0b7d (commit)
       via  bfd019e1c9272143a637747cf8dbd66774696483 (commit)
       via  6da3e7abfa0b4129156bb7e9f6797a07d4fbbb3e (commit)
       via  b9a5b6889648f6888b8796a54f03a6f7e60cd728 (commit)
       via  5188e51e07df8f0c1dc34ee70d4cb2d3d53a6016 (commit)
       via  e73abc3fd8398051498406b2a8e81041050352d9 (commit)
       via  fd2104e10011b87d6558e8623d629da4cee82b25 (commit)
       via  d9fc15ceb74cdc66487ba9aaed04246170729640 (commit)
       via  7731fa51f095e615975cd53d35ba3cb681b82df1 (commit)
       via  97fed7964411b7bed4d8ad5bc895966de7e6b2b3 (commit)
       via  924870103590032b33a94b471fc90ed08f4072c6 (commit)
       via  5bfbebe93fba98a3b5c1f64482823d53265aed5b (commit)
       via  b7da2544e1d967b9c3afff6cc93686ddeef09b59 (commit)
      from  0bc1a5a1eebddc094acd9eb181aa9dcaddef2f5f (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit b84ba63c22f65fffebf1dec32a982be2d5a83536
Author: Ben Pfaff <address@hidden>
Date:   Mon Apr 25 21:37:18 2011 -0700

    sys-file: Add test to write non-ASCII to most .sav string fields.
    
    Bug #33036.

commit de8fc417b1268addaa8b65f7be78c80c61bc0b7d
Author: Ben Pfaff <address@hidden>
Date:   Sun Apr 24 21:42:54 2011 -0700

    sys-file-reader: Add tests for non-ASCII characters and encodings.

commit bfd019e1c9272143a637747cf8dbd66774696483
Author: Ben Pfaff <address@hidden>
Date:   Sun Apr 24 21:41:30 2011 -0700

    DISPLAY FILE LABEL: Display in a more natural way.

commit 6da3e7abfa0b4129156bb7e9f6797a07d4fbbb3e
Author: Ben Pfaff <address@hidden>
Date:   Sun Apr 24 21:41:02 2011 -0700

    MRSETS: Recode counted value to UTF-8 before displaying.
    
    Otherwise they display incorrectly if a counted value contains
    non-ASCII characters.

commit b9a5b6889648f6888b8796a54f03a6f7e60cd728
Author: Ben Pfaff <address@hidden>
Date:   Sun Apr 24 13:19:15 2011 -0700

    sys-file-reader, sys-file-writer: Fix encoding problems for mrsets.

commit 5188e51e07df8f0c1dc34ee70d4cb2d3d53a6016
Author: Ben Pfaff <address@hidden>
Date:   Sat Apr 23 20:15:18 2011 -0700

    sys-file-writer: Fix encoding of several string fields.
    
    PSPP keeps most string data in the dictionary in UTF-8.  The system
    file writer needs to recode this data into the correct encoding, but
    in several cases it failed to do so.  This fixes the problem.
    
    Thanks to Mindaugas for reporting the problem and to John Darrington
    for help diagnosing it.
    
    Bug #33036.

commit e73abc3fd8398051498406b2a8e81041050352d9
Author: Ben Pfaff <address@hidden>
Date:   Sat Apr 23 22:10:20 2011 -0700

    sys-file-reader: Take string encoding into account for text records.
    
    The 'encoding' member of struct sfm_reader was not filled in anywhere,
    so it was always NULL, which meant that the recode operation in
    open_text_record() was a no-op.

commit fd2104e10011b87d6558e8623d629da4cee82b25
Author: Ben Pfaff <address@hidden>
Date:   Sat Apr 23 21:45:19 2011 -0700

    variable: Make var_set_label() use the variable's own encoding.
    
    I don't see any reason to make the caller supply this.  It just makes
    code harder to read and write.

commit d9fc15ceb74cdc66487ba9aaed04246170729640
Author: Ben Pfaff <address@hidden>
Date:   Sat Apr 23 21:40:48 2011 -0700

    dictionary: Make dict_create() take the new dictionary's encoding.
    
    There are several places in the PSPP tree that create dictionaries,
    but few of them actually set an encoding.  This causes most
    dictionaries to be in the default encoding, which is often not
    correct.
    
    By making dict_create() take the encoding as a parameter we force
    the caller to think about the encoding issue up-front.

commit 7731fa51f095e615975cd53d35ba3cb681b82df1
Author: Ben Pfaff <address@hidden>
Date:   Sat Apr 23 12:01:35 2011 -0700

    dictionary: Set encoding early when cloning a dictionary.
    
    Many operations that involve the names of variables and other entities
    in a dictionary depend on the dictionary's encoding, so it is
    potentially important to have the encoding set properly when adding
    other entities to the dictionary.
    
    I did not check that this fixes an actual bug.

commit 97fed7964411b7bed4d8ad5bc895966de7e6b2b3
Author: Ben Pfaff <address@hidden>
Date:   Sat Apr 23 11:59:49 2011 -0700

    short-names: Consider character encoding when making short names.
    
    Variable names and short names are always in UTF-8, but the length of
    short names needs to be limited to 8 bytes in the dictionary encoding,
    not in UTF-8.  This commit fixes that problem.

commit 924870103590032b33a94b471fc90ed08f4072c6
Author: Ben Pfaff <address@hidden>
Date:   Sat Apr 23 11:40:42 2011 -0700

    short-names: Drop redundant call to var_set_short_name().
    
    This function always calls var_set_short_name() twice, so we can drop
    the first call.

commit 5bfbebe93fba98a3b5c1f64482823d53265aed5b
Author: Ben Pfaff <address@hidden>
Date:   Sat Apr 23 21:59:38 2011 -0700

    dissect-sysfile: Don't omit the last in a series of text tokens.
    
    Otherwise dissect-sysfile would not print the last long string
    variable name written by sys-file-writer, because it did not include
    a separator byte after the last record.  (This was obvious running
    dissect-sysfile on a system file with only one variable.)

commit b7da2544e1d967b9c3afff6cc93686ddeef09b59
Author: Ben Pfaff <address@hidden>
Date:   Sat Apr 23 12:02:04 2011 -0700

    str: Always null-terminate string in str_format_26adic().
    
    It seems like a good idea to always supply a null terminator, even on
    error.

-----------------------------------------------------------------------

Summary of changes:
 perl-module/PSPP.xs                        |    5 +-
 perl-module/t/Pspp.t                       |    4 +-
 src/data/dataset.c                         |    3 +-
 src/data/dictionary.c                      |   28 ++---
 src/data/dictionary.h                      |    3 +-
 src/data/gnumeric-reader.c                 |    5 +-
 src/data/por-file-reader.c                 |    5 +-
 src/data/psql-reader.c                     |   14 +-
 src/data/short-names.c                     |   63 ++++------
 src/data/sys-file-reader.c                 |   83 +++++++-----
 src/data/sys-file-writer.c                 |  159 +++++++++++++++--------
 src/data/variable.c                        |   29 ++--
 src/data/variable.h                        |    3 +-
 src/language/data-io/combine-files.c       |   20 +--
 src/language/data-io/data-list.c           |   15 +-
 src/language/data-io/get-data.c            |    2 +-
 src/language/dictionary/apply-dictionary.c |    3 +-
 src/language/dictionary/mrsets.c           |   10 +-
 src/language/dictionary/sys-file-info.c    |    6 +-
 src/language/dictionary/variable-label.c   |    3 +-
 src/language/stats/aggregate.c             |    5 +-
 src/language/stats/descriptives.c          |    6 +-
 src/language/stats/rank.q                  |    8 +-
 src/libpspp/str.c                          |    9 +-
 src/ui/gui/psppire-data-editor.c           |    5 +-
 src/ui/gui/psppire-var-store.c             |    3 +-
 src/ui/gui/text-data-import-dialog.c       |    4 +-
 tests/data/sys-file-reader.at              |  196 ++++++++++++++++++----------
 tests/data/sys-file.at                     |   75 +++++++++++
 tests/dissect-sysfile.c                    |    4 +-
 tests/language/utilities/title.at          |   12 +--
 tests/perl-module.at                       |   12 +--
 32 files changed, 478 insertions(+), 324 deletions(-)


hooks/post-receive
-- 
GNU PSPP