[Pan-devel] Some modification suggestions (go to next group & copying urls)

[Tatu Lahtela]

Hi!

I'm new to this list, so I don't know if these things are discussed
before(or your methods at all for that matter). But anyway, I made some
modifications to the code to make it more usabe, for me anyway.

a) When I type "g" to go to the next unread group, I want the group list
to center itself to the current group. If I understood the code, that
would be:

-clip-
$ diff -c1 grouplist.c grouplistOld.c
*** grouplist.c Tue Oct 21 11:00:52 2003
--- grouplistOld.c      Mon Aug  4 18:35:13 2003
***************
*** 1247,1249 ****
        }
!       grouplist_refresh_nolock();
        pan_unlock ();
--- 1247,1249 ----
        }
! 
        pan_unlock ();

-clip-

b) Without painting an url, there's no way to copy it.  This feature is
very useful when you e.g. want to copy the url and launch it on a
different machine then where Pan is running. My gtk is rusty so I just
made the middle button copy the url into the clipboard:

-clip-

diff -c1 text.c textOld.c 
*** text.c      Tue Oct 21 12:22:56 2003
--- textOld.c   Tue Oct 21 12:09:25 2003
***************
*** 64,66 ****
  PanCallback * current_article_changed = NULL;
- gint url_len;
  
--- 64,65 ----
***************
*** 1134,1136 ****
                retval = gtk_text_iter_get_text (&begin, &end);
-               url_len = gtk_text_iter_get_line_offset(&end)-
-                        gtk_text_iter_get_line_offset(&begin);
        }
--- 1133,1134 ----
***************
*** 1149,1151 ****
  
!       if (event->button==1 )
        {
--- 1147,1149 ----
  
!       if (event->button==1 || event->button==2)
        {
***************
*** 1166,1183 ****
        }
-       /* Copy the url into the clipboard with the middle button */
-         else if ( event->button == 2 )
-         {
-               char * url = get_url_from_location (w, (int)event->x, 
(int)event->y);
-               if (url != NULL)
-               {
- 
-                       GtkClipboard * clipboard = 
gtk_clipboard_get_for_display (
-                               gdk_display_get_default(), 
GDK_SELECTION_PRIMARY);
-                       gtk_clipboard_set_text(clipboard,
-                                              url,
-                                              url_len);
-               }
- 
- 
-       }
  
--- 1164,1165 ----


-clip- 


-- 
Tatu Lahtela <address@hidden>