Re: [PATCH] OS/2 patches for master branch, try 2

[Gary V. Vaughan]

On Nov 20, 2014, at 10:33 PM, Gary V. Vaughan <address@hidden> wrote:
> 
> On Nov 20, 2014, at 4:55 AM, KO Myung-Hun <address@hidden> wrote:
>> These are OS/2 patches for master branch. Patches for 1.4 branch are
>> reflected.
>> 
>> [PATCH 1/5] configury: support DLLs on OS/2
> 
> Agreed.  But these flags apply to more than just OS/2, so I turned on 
> -avoid-version and -no-undefined unconditionally.
> 
>> [PATCH 2/5] m4: support to load modules on OS/2
> 
> In principle, these seem like good changes, but the implementation is not as 
> clean as it could be, considering many of these changes certainly may apply 
> on more than just OS/2.  I've rewritten equivalents to everything except 
> module name truncation to 8 characters maximum, which I'll figure out how to 
> do nicely tomorrow.

On reflection, falling back to the system dlopen() search path is both a 
security risk, and breaks the process for loading frozen files in the current 
format, so I reverted that part.  If you need that functionality, then set 
M4PATH appropriately in the environment, or from a wrapper script e.g.:

  M4PATH=$LD_LIBRARY_PATH m4

I found a nice way to consistently perform path truncation during path 
searching, though I only tested it lightly from gdb, so please confirm if it 
works for you as expected on OS2.

>> [PATCH 3/5] configury: append $EXEEXT suffix to the executable,
>> [PATCH 4/5] configury: add -Zargs-resp to LDFLAGS on OS/2.
>> [PATCH 5/5] esyscmd: fdopen() with a text mode explicitly on OS/2.
> 
> Ack.
> 
> Effectively applied and pushed everything here, or equivalents - save module 
> name truncation.

Cheers,
-- 
Gary V. Vaughan (gary AT gnu DOT org)