Re: parallel build bug in git M4

[Gary V. Vaughan]

Hi Eric, Ralf,

2009/3/19 Ralf Wildenhues <address@hidden>:
> Hi Eric,
>
> * Eric Blake wrote on Thu, Mar 19, 2009 at 02:31:26AM CET:
>> According to Ralf Wildenhues on 3/14/2009 6:36 AM:
>> >
>> > I have been thinking about this a bit, and the only real solution that
>> > I've found that doesn't involve other races or adding .NOTPARALLEL was
>> > to reintroduce a subdir makefile.  But then we can put all doc/ rules
>> > there again; see the patch below.  Do you see any other possibilities?
>>
>> I'm still thinking about it.  Gary originally introduced the non-recursive
>> make; and for the source files and incremental builds, it makes a big
>> difference.

I read 'recursive make considered harmful' and for those reasons tried
to move as much of the build into a single makefile as humanly possible.

> The reintroduction of doc/Makefile.am carries only a negligible speed
> penalty.

Speed wasn't too much of an issue for me really, I was more interested
in having a single make aware of the dependencies across the whole
project, and the advantages that brings.

>> But the documentation doesn't have much that runs in
>> parallel, and making the man page occur in a recursive make doesn't seem
>> like too big a penalty from my point of view if it avoids the race.  I'd
>> really like to hear from Gary on this issue, though, before pushing anything.
>
> Certainly.

Having said that, I don't think there's any reason to get hung up on it, and
have no strong objection to introducing a sub-make when it improves
correctness :)  I can't see any other means of avoiding the race, so it seems
like a win to apply Ralfs patch.

Please go ahead.

Cheers,
    Gary
-- 
Email me:          address@hidden                        (\(\
Read my blog:      http://blog.azazil.net              ( o.O)
And my other blog: http://www.machaxor.net              (uu )o
...and my book:    http://sources.redhat.com/autobook  ("("_)