Re: argv_ref patch 25: allow NUL in quote and comment delimiters

[Eric Blake]

Eric Blake <ebb9 <at> byu.net> writes:

> Next in the series, this time to handle embedded NUL in quote and comment
> syntax.  Quotes and comments were already tracking length, but there were
> a number of places that were assuming they did not contain NUL or which
> required a NUL terminator instead of using the length.  The patch doesn't
> use any more memory, and in some cases can use slightly less (where a NUL
> terminator is now omitted); and I didn't notice any obvious speed differences.

Phooey - I was timing the wrong build.  In looking at this closer, I'm seeing 
some noticeable degredation in speed, on the order of 6%; I'm trying to see if 
there is anything obvious that could be causing this slowdown.  My first guess 
is that the MATCH macro in input.c might be the culprit, since it is on a hot 
path (finding the close-quote to quoted strings).

-- 
Eric Blake