m4-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: 'make installcheck' vs. './configure --program-prefix'


From: Eric Blake
Subject: Re: 'make installcheck' vs. './configure --program-prefix'
Date: Tue, 15 Apr 2008 23:03:55 +0000 (UTC)
User-agent: Loom/3.14 (http://gmane.org/)

Eric Blake <ebb9 <at> byu.net> writes:

> 
> Ralf noticed on the libtool list that --program-prefix can interfere with
> 'make installcheck'.  I discovered that m4 had the same problem, fixed as
> follows for the branch (I still need to test whether head has the same
> problem, although that might be considered an autotest issue).

I recently regressed on this on branch-1.6, by introducing a test that 
recursively calls m4.  In the installed case, it should instead recursively 
call __program__ (in the uninstalled case, it hasn't yet been renamed, so 
calling m4 didn't trigger any problems).  I'm still working on making the 
master branch support this, but it is taking more work (in part because it is 
harder to trace through libtool wrappers to test with a cooked executable 
name).  And I may still yet borrow an idea from coreutils' maint.mk, to enhance 
the maintainer-specific rule 'make my-distcheck' intentionally add a crippled 
m4 at the front of the PATH, to ensure that all the tests properly use gm4 when 
the name has been transformed.

>From 14840bcf0e8fd964aaec8459441d8b5d5b791624 Mon Sep 17 00:00:00 2001
From: Eric Blake <address@hidden>
Date: Tue, 15 Apr 2008 14:27:54 -0600
Subject: [PATCH] Another 'make installcheck' fix.

* doc/m4.texinfo (Diversions): s/m4/__program__/ in case
--program-prefix was active.

Signed-off-by: Eric Blake <address@hidden>
---
 ChangeLog      |    6 ++++++
 doc/m4.texinfo |    2 +-
 2 files changed, 7 insertions(+), 1 deletions(-)

diff --git a/ChangeLog b/ChangeLog
index a9fc7f5..a98deb3 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,9 @@
+2008-04-15  Eric Blake  <address@hidden>
+
+       Another 'make installcheck' fix.
+       * doc/m4.texinfo (Diversions): s/m4/__program__/ in case
+       --program-prefix was active.
+
 2008-04-14  Eric Blake  <address@hidden>
 
        Stage 21: $@ concatenates builtins, m4wrap takes builtins.
diff --git a/doc/m4.texinfo b/doc/m4.texinfo
index 52fc77b..4572e79 100644
--- a/doc/m4.texinfo
+++ b/doc/m4.texinfo
@@ -4960,7 +4960,7 @@ ifdef(`__unix__', ,
 ')m4exit(`77')')dnl
 changequote(`[', `]')dnl
 syscmd([echo 'divert(1)hi
-format(%1000000d, 1)' | m4 | sed 1q])dnl
+format(%1000000d, 1)' | ]__program__[ | sed 1q])dnl
 @result{}hi
 sysval
 @result{}0
-- 
1.5.5








reply via email to

[Prev in Thread] Current Thread [Next in Thread]